Giter VIP home page Giter VIP logo

Comments (6)

sergejsha avatar sergejsha commented on June 27, 2024 1

Moreover, it is always possible to resolve this ambiguity manually in the constructor. Just add DependencyScope as a constructor parameter and then request from the scope whatever needed.

from magnet.

sergejsha avatar sergejsha commented on June 27, 2024

Before getting a dependency from the scope someone needs to put this dependency into the scope. How would you write the code for putting it in this particular case?

from magnet.

AlexWih avatar AlexWih commented on June 27, 2024

As T is a subtype of Number then the DependencyScope should receive some subtype of Number, i.e.:
dependencyScope.register(Long.class, Long.MAX_VALUE);

from magnet.

sergejsha avatar sergejsha commented on June 27, 2024

And in case when I put

dependencyScope.register(Long.class, Long.MAX_VALUE);
dependencyScope.register(Byte.class, Byte.MIN_VALUE);

which value should be provided to constructor of FooImpl?

from magnet.

AlexWih avatar AlexWih commented on June 27, 2024

I believe it is a design decision.
I would expect runtime error as both dependencies match.
Or alternatively the qualifiers could be utilised as Dagger does.

from magnet.

sergejsha avatar sergejsha commented on June 27, 2024

I was thinking about adding qualifiers later on, but they won't help here. It will still be possible to add both Float and Byte types with the same qualifier, which is fully valid construct, and this will produce ambiguity when the type is requested though a generic type. I believe even Dagger will fail to inject a generic type due to mentioned type ambiguity.

I'm going to disallow generics in implementation constructors for now. However compiler will fail with a meaningful message.

from magnet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.