@Subscribe visibility? about tinybus HOT 5 CLOSED

This was an explicit design decision. The reason for that is that future versions of TinyBus may use generated code instead of runtime reflection. Keeping methods public will give more flexibility if case of such changes in the future.

from tinybus.

Make sense. Would be nice to generate a warning though ;)

from tinybus.

You mean when a method is private of protected?

On Mon, Mar 9, 2015 at 4:48 PM, nono240 [email protected] wrote:

Make sense. Would be nice to generate a warning though ;)

—
Reply to this email directly or view it on GitHub
#31 (comment).

from tinybus.

Yes, at compile time of course - at least for Android Studio. Dagger raise an error is the field is private.

from tinybus.

Agree. That what I was thinking about. I didn't want to introduce these checks at runtime. But it's a good idea to have them at compile time. Just created a separate TODO for it.

from tinybus.