jsftp won't auth about jsftp HOT 9 CLOSED

I'm getting this same issue. I'm trying to figure out what's up, but am having trouble tracking it down. I don't know if I npm updated or if it's cuz I updated node to 0.5.8 or if it was broken before I updated... :-/

Either way, this is definitely broken for 0.5.8, I'll try and roll back and see if that fixes it.

from jsftp.

Oddly enough, mine also started 2 days ago... I don't see any activity on the module though. Must be a node issue?

from jsftp.

In my case I had node.js 0.4.12 for a while and I didn't have the bug with this version last week.

Since I didn't have the problem last week and that the last jsftp update is from 4 weeks ago I think I was using a out-of-date version of jsftp.

I can't reproduce the bug with the 0.1.5 version.

The first bad commit is 47816c3.

@CrabDude Does using the 0.1.5 version fixes the problem for you too?

from jsftp.

Here's an expect script using netcat to reproduce the bug I have :

#!/usr/bin/env expect

spawn nc -vl 9999
set timeout -1
expect "Connection from * accepted" { send "220  FTP server (Hummingbird Ltd. (HCLFTPD) Version 7.0.0.0) ready.\r" }
expect -nocase "user *" { send "331 Password required for this_user.\r" }
expect -nocase "pass *" { send "230 User agent logged in.\r" }

expect -nocase "SYST" { send "500 'SYST': command not understood.\r" }
expect -nocase "FEAT" { send "500 'FEAT': command not understood.\r" }
expect -nocase "TYPE I" { send "200 Type set to I.\r" }
expect -nocase "CWD *" { send "250 CWD command successful.\r" }
expect -nocase "PWD" { send "257 '/' is current directory.\r" }

Using 1eb4342, jsftp never send the password.

I get this :

bbigras@ubuntu:~/node-ftp$ expect test_ftp
spawn nc -vl 9999
Connection from 127.0.0.1 port 9999 [tcp/*] accepted
220  FTP server (Hummingbird Ltd. (HCLFTPD) Version 7.0.0.0) ready.
user user
331 Password required for user.

It seems self.raw.pass's callback is never called.

from jsftp.

[REMOVED]

from jsftp.

@CrabDude Yes 47816c3 is the bad commit. Like I said in one of my comments :) git bisect rules.

from jsftp.

Hi @BrunoQC,

Testing with your simple auth script, it works properly with my FTP server in node 0.4.12 and 0.6.2. I think it is very likely that it is related to the server you are using, and I'd like to test there if possible. Is there any way you can give me a dummy account with which I can test?

Thanks,

Sergi

from jsftp.

In case anyone stumbles upon this same issue, see:

#16

from jsftp.

Pull Request #16 has been merged. @BrunoQC can you try again?

from jsftp.