ARM version not detected for 32-bit arm versions about bindings-cpp HOT 3 OPEN

I think that serialport or one of its dependency does somewhere overwrite the process.config.variables.arm_version with "default" as the normal nodejs install on this system shows "7" for process.config.variables which is correct. Or maybe VSCode or electron does overwrite it.

from bindings-cpp.

My current patch is to replace the var armv line in node-gyp-build with following:

// ARMv7 detection patched to avoid arm_version === "default" on other arm systems than arm64 ones
var armv = process.env.ARM_VERSION || (arch === 'arm64' ? '8' : (arch === 'arm' ? (vars.arm_version === 'default' ? '7' : vars.arm_version) : '')) || ''

This defaults to armv7 for arm systems where the arm_version has been overwritten to "default".

Note that's not a node-gyp-build bug as it functions perfectly well if the global process.config.variables.arm_version variable would not be overwritten with "default".

from bindings-cpp.

It's not something serialport does directly.

from bindings-cpp.