Giter VIP home page Giter VIP logo

Comments (3)

BokhodirUrinboev avatar BokhodirUrinboev commented on May 20, 2024

Good evening can't we make custom exception middleware and leave it to programmer handle the rest of it
We just need to make initial structure for in server side register it in program.

app.UseMiddleware<ErrorHandlerMiddleware>();

For example we can use some class for custom exception type

` public class HttpResponseException
{
public int? status { get; }
public object? internalError { get; }
public string? message { get; }
public string? code { get; }
public string? name { get; }

    public HttpResponseException(int? status, object? internalError, string? message, string? code, string? name)
    {
        this.status = status;
        this.internalError = internalError;
        this.message = message;
        this.code = code;
        this.name = name;
    }
}`

And write handler for it and leave it to programmer to handle it

` public class ErrorHandlerMiddleware
{
private readonly RequestDelegate _next;
private HttpResponseException httpResponseException { get; set; }
public ErrorHandlerMiddleware(RequestDelegate next)
{
_next = next;
}
public async Task Invoke(HttpContext context)
{
try
{
await _next(context);
}
catch (Exception ex)
{
var response = context.Response;
response.ContentType = "application/json";

            switch (ex.Message)
            {
                case "err-404":
                    httpResponseException = new HttpResponseException(status: 400, internalError: ex.InnerException,
                        message: "Entity not found", code: ex.Message, name: "Bad Request");
                    break;
                default:
                    httpResponseException = new HttpResponseException(status: 500, internalError: ex.InnerException,
                        message: ex.Message, code: ex.Message, name: "Internal Server Error");
                    break;
            }

            var result = JsonSerializer.Serialize(httpResponseException);
            response.StatusCode = (int)httpResponseException.status;
            await response.WriteAsync(result);
           
        }
    }
}`

So this way we could make custom Exceptions more like json api format ant it would be cleaner than throw 500 and some text
don't u think?

from stl.fusion.

BokhodirUrinboev avatar BokhodirUrinboev commented on May 20, 2024

And we should probably add it to the template

from stl.fusion.

alexyakunin avatar alexyakunin commented on May 20, 2024

@BokhodirUrinboev sorry, I noticed this comment very late. This approach certainly works, the "meta issue" was more about adding dedicated exception types for some of errors thrown by Fusion.

And v6 completely overhauled Fusion's communication stack replacing it with Stl.Rpc, so this approach is less necessary there: Stl.Rpc's default is to serialize the exception type & message automatically.

from stl.fusion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.