Giter VIP home page Giter VIP logo

Comments (7)

jdm avatar jdm commented on August 25, 2024

This leads to fun messages like: <crowbot> servo-mac1 is overdue! (build started in 16 minutes)

from crowbot.

carlosmcgregor avatar carlosmcgregor commented on August 25, 2024

That is sure a fun message!

Could we make a combination of both ETA and start time? Only check ETA > .5 after 90 minutes have passed.

from crowbot.

jdm avatar jdm commented on August 25, 2024

We could, but it's not clear to me whether that would be a meaningful improvement. I was watching the ETA data shift wildly over the course of an unexceptional run, so I don't really know what it's actually supposed to tell us.

from crowbot.

jdm avatar jdm commented on August 25, 2024

Additionally, http://trac.buildbot.net/ticket/540 says that the ETA is "badly inaccurate" in the 0.8.x versions, and we're using 0.8.12 according to https://github.com/servo/saltfs/blob/master/buildbot/master/init.sls#L9.

from crowbot.

carlosmcgregor avatar carlosmcgregor commented on August 25, 2024

Thank you for the comprehensive explanation on why ETA is not working out. I will be sticking to start times for the patch.

from crowbot.

carlosmcgregor avatar carlosmcgregor commented on August 25, 2024

Since we will be comparing UNIX timestamps, there will be no need to implement timezones. Please correct me if I am wrong.

There are no running builds now in the dead of the night, so I will be testing this tomorrow before doing the pull request.

from crowbot.

jdm avatar jdm commented on August 25, 2024

Let's see if the results make sense without any timezone logic.

from crowbot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.