Responding to GitHub's review events about homu HOT 11 OPEN

Yeah, there are two separate features here:

• GH approval comments should definitely be parsed for homu commands
• GH approvals should themselves count as an approval, provided an option is set

I don't really have time to implement this but willing to accept a patch for either.

from homu.

from homu.

Ah, that is a fair point, I guess you can't self-review on github. Hmm.

from homu.

On the other hand, you can always use the r+ feature in conjunction with this, rather than instead-of.

from homu.

from homu.

I'd like to have a setting that does so. If a reviewer wants to give feedback and 'passively approve' (i.e, allow the submitter to self-r+), they can always leave a 'comment review' rather than 'approve/disapprove'.

from homu.

Often folks use the GitHub review thing to say "approved, but here are some minor changes you should make and then self-r+"

The r+ command is only interpreted you mention @bors on the same exact line, so I think this cause of misapproval would be rare.

from homu.

You misunderstand, the proposal is (in part) to make an approved review itself count as an r+

from homu.

The r+ command is only interpreted you mention @bors on the same exact line, so I think this cause of misapproval would be rare.

My interpretation of @Manishearth's comment was that pressing "Approve" in github should not translate to the equivalent of r+, because people currently use "Approve Review" in github and tell a user to self-r+ to cause a merge.

from homu.

Okay my understanding was that homu should respond to review comments (which are currently ignored).

I agree that pressing "Approve" should not be equivalent to r+, without mentioning @bors the intention is not clear enough.

from homu.

I would like to try and encourage my team to use the "Approve" feature, to give it an equivalence to r+. Using r+ (e.g, self-r+) would also be allowed. So it would be nice if this were an option that could be enabled.

My motivation is to get people to use the github review feature, for example to request reviews, and also to give them a nudge UI nudge towards leaving comments using the review feature (which is only seen on the 'diff' section).

from homu.