MOD retrigger effect is broken. about mikmod HOT 2 OPEN

Please note that the various versions of ProTracker do not share the same replayer code and may differ in details when it comes to effect reproduction. ProTracker 2.3d is the most-used version and very few people used ProTracker 3 in comparison, so you should always compare MOD behaviour against ProTracker 2.3d (or bubsy's cross-platform clone of that version).

Retrigger in particular is one of those quirky effects that are handled vastly differently between different trackers (as you noticed with FT2). If you want to fix it, I suggest to take a very surgical approach and only fix it one format at a time.

from mikmod.

That is good to know. I just tried a similar test in ProTracker v2.3d and I got the same result as in ProTracker 3 (though I found two versions called "ProTracker v2.3d", I'm not sure which is correct). I'd definitely like to limit these sorts of fixes/tweaks on per-format basis but in this case the current implementation is plain wrong regardless of format. I'd like to at least correct that first. The tracker-specific behavior probably doesn't matter much for that part of things...

For reference though, formats aside from MOD/S3M with retrigger currently are implemented with:

• DSMI AMF: S3M Qxx
• ASYLUM AMF: ???

        if (effect == 0x1b) {
                return 0; /* UniEffect(UNI_S3MEFFECTQ,dat) ? */
        }

• DSM: PT E9x
• FAR: PT E9x (for now. I want to give this format a close look eventually because other effect conversions are definitely wrong!)
• GDM: S3M Qxx
• IMF: S3M Qxx
• IT: S3M Qxx
• MED: currently being fixed independent of this issue and the reason I found this bug in the first place :(
• MTM: PT E9x
• ULT: PT E9x
• XM: PT E9x and S3M Qxx (for Rxx)

edit: clarification.

from mikmod.