Giter VIP home page Giter VIP logo

Comments (4)

sfirke avatar sfirke commented on August 24, 2024

Eh, it's unclear. If you're doing further operations on the result, like a join, this is an advantage. But, you should call clean_names() now, or should have called it before tabyl(). So it's kind of hand-holdy.

If you're not doing further operations, and are just printing to console, then the status quo is more useful in that it confirms what you did. And if you're printing it in a markdown table, you'll probably need to tweak the name anyway.

It's easy to add a clean_names call to the tabyl() function but I'm not sure it's worth it.

from janitor.

sfirke avatar sfirke commented on August 24, 2024

I'm fine with retaining the dirty name, like:

mtcars %>% mutate(`bad name` = cyl) -> k
tabyl(k$`bad name`)

But unfortunate that this:

mtcars %>% mutate(`bad name` = cyl) %>% tabyl(`bad name`)

Gives "bad.name" instead of "bad name".

from janitor.

sfirke avatar sfirke commented on August 24, 2024

Oh and this behavior (default and piped) should match that of crosstab()

from janitor.

sfirke avatar sfirke commented on August 24, 2024

Fixed - now piped calls to both functions will return exactly the variable name, with whatever warts it has, and default calls will return the data.frame name and $, e.g., mtcars$cyl or mtcars$bad name``.

from janitor.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.