Problem with Secondary Source Selection and eps about sfs-matlab HOT 5 CLOSED

I have applied your proposed change from eps to 0 for a pint source (L124) in the branch fix_ssd_selection. If I run your example the output looks identical to me.

from sfs-matlab.

As I understood it this is the crucial part why this bug happens: "two secondary sources are exactly on this bound", correct?
I can reproduce the behavior for -eps, do you know why this is working and can we somehow become independent of the sign?

from sfs-matlab.

I understood the eps as the maximum value, which may be added or substracted to the true result of an arithmetic operation due to numerical noise, i.e. finite numerical resolution. Assuming the true value of the scalar product is 0, its calculated value might be between +eps and -eps. I guess choosing -eps for comparison is the conversative approach, as all sources are selected, where the scalar product yields greater-equal -eps. However, there might be a source, where the true is smaller than 0 and which are selected erroneously due to this selection criterion.

from sfs-matlab.

I think you are right and it is more conservative to use a negative value. I tested the same for ls as source and added now -2*eps as the criterium as for ls -eps was not enough.

from sfs-matlab.

Btw, for focused sources and plane wave there was no error with your loudspeaker array, so I didn't changed the selection criterium.

from sfs-matlab.