Tests fails with the latest Abseil about sfizz HOT 7 CLOSED

20230802.rc2 also works.

from sfizz.

20230802.rc2 also works.

which is older than 20230802.1, that seems to be the only one we can use before the 2024 series.
Let's see what @paulfd think.

from sfizz.

It might be related to Address sanitizer. The tests succeeds when I set SFIZZ_ASAN to OFF.
Abseil might keep invalid address on hash maps.

from sfizz.

I had that suspect few hours ago, anyways, let's see. Meanwhile, would you like to join our Discord or Matrix chat?

from sfizz.

The tests on ubuntu 22.04 with the following script are failed.
I think the auto tests with new tags fail with the Abseil version.
They also fail when ubuntu's abseil version becomes newer.

#/bin/bash
BT=Debug
#BT=RelWithDebInfo
TESTDIR=build_asan
cmake -G Ninja -B ${TESTDIR} -S . -D CMAKE_BUILD_TYPE=${BT} -D SFIZZ_TESTS=ON -D SFIZZ_ASAN=ON -D SFIZZ_USE_SYSTEM_ABSEIL=OFF && \
cmake --build ${TESTDIR} --config ${BT} --parallel 2 --target sfizz_tests && \
ctest --build-config ${BT} --parallel 1 --output-on-failure --stop-on-failure --test-dir ${TESTDIR}

from sfizz.

Thanks again for the report. It looks like to me that moving the hash map invalidates references, which tends to be validated by this comment. Since the target vector is grown incrementally during loading, and the hashmap is in the vector, it might get moved if the vector reallocates for more space.

I'll continue investigating.

from sfizz.

The changelog entry was:

• Abseil's hash tables now detect many more programming errors in debug and sanitizer builds.

It's actually our bug, not abseil's. I have a potential fix in #1242, lmk if it helps!

from sfizz.