Comments (5)
Hrm... It's easy enough to add, and I don't mind doing it. But out of curiosity, why is it useful? I had thought that there would be two basic use cases:
- Adaptation always enabled or disabled, and therefore set once programmatically.
- Adaptation always controlled by some application UI element, and therefore set on interaction with that element.
When would you want to query the state? How would your application lose track of whether or not adaptation was enabled?
from shaka-player.
I agree with you that it is easy enough to keep track of but if it's ever ambiguous what the starting state is or just not known what the starting state is, it seems like there is the potential to get out of sync. To me it seems like it's the responsibility of the player to manage its own state and that way whoever is using it can't ever get out of sync or make the wrong assumption about what state it is in.
Also, I'm happy to submit a pull request so you can concentrate on higher priority stuff. Maybe this won't be generally considered useful.
from shaka-player.
I'm not sure it would get out of sync, though. It's easy to set explicitly as soon as Player is created.
In any case, this debate is purely philosophical. I don't object to the feature. Please feel free to submit a pull request.
It may be a bit more pain than contributing to the typical open-source project, but Google does require a one-time contributor agreement as outlined in CONTRIBUTING.md.
And thanks for offering to contribute. You're the first!
from shaka-player.
this is the way of checking if abr is enabled or not
shakaPlayer.getConfiguration().abr.enabled
it returns true or false accordingly.
from shaka-player.
@Awais-cb, this thread was closed 2.5 years ago. Please try not to reopen very old threads. Shaka Player looks very different today than it did in 2015. Thanks!
from shaka-player.
Related Issues (20)
- Logging : Shaka UI should be in debug? HOT 2
- Missing HLS replay functionality HOT 4
- vttcue HOT 3
- Failed to execute 'createElement' on 'Document' HOT 1
- I want to maintain a constant time difference at all times. HOT 2
- Buffering event fired too late HOT 4
- Support time shifting in live streams using IndexedDB to store media segment HOT 2
- How to run shaka player at custom domain for testing HOT 3
- Handle token expiration for API requests HOT 8
- Exception in UITextDisplayer constructor
- webOS 4032 error in compiled version but not debug version HOT 22
- Cant use player.attach for playing the next video while creating the functionality for playing the next video HOT 3
- Documented Code Sample for Preload API seems to be incorrect HOT 1
- 3 Line 608 caption displays as 1 line on Safari HOT 2
- Is it possible to play a video chunk as soon as a response is received? HOT 2
- Unexpected buffer range for reference on old device HOT 5
- How can i add eventlistener like click doubleclick to player HOT 2
- There is a 6 second buffer and then suddenly disappears. HOT 1
- Summary of known compiler issues HOT 2
- Bruteforcing bad streams HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shaka-player.