replaceChild vs appendChild about base-element HOT 5 CLOSED

I vote for option A: browser methods are standardized, transparent and keep the module scope more focused (e.g. only concerned about creating elements, not attaching).

from base-element.

A for me as well

from base-element.

I think it's worth keeping in mind that base-element already concerns itself with attaching

Given this I can see an argument being made for C.

I think that the user should be 100% responsible for attaching, but I can also see how having base-element handle attaching might be very handy/natural when working with for some of the popular js frameworks out there. I don't use any so I won't comment further here.

Option A for me

from base-element.

Option A seems like the right thing to do.

What if there were generic helper modules for mountTo(), appendTo() or even prependTo()?

Maybe unnecessary, but could be useful.

Usage might look something like:

var mountTo = require('mount-to')
var el = createElement()

mountTo(document.querySelector('.app'), el)

from base-element.

👍 Option A it is! Thanks all! Very much appreciated!

@sethvincent The separate module is a great idea to reduce the verbosity too, thanks!

from base-element.