Comments (8)
It's also fix for #20 so it's not completely enhancement.
I guess download progress indicator is nice-to-have, but not most important atm.
Take a look at ebe27b7.
I don't know how you guys take care of permissions, but it will work with workaround for those who need to develop with nodewebkit.
from nodewebkit.
@adiq Nice! That is basically where my branch stopped on this enhancement/bugfix as well. I think we should send a pull request upstream into download or rather decompress to copy the modes of the files it extracts.
We could manually fs.chmodSync
+x the files that need it but copying the mode from the archive seems like an easier path. @kevva is a pretty active and awesome developer too and I bet he'd merge a PR for it if one was sent his way on decompress. I just haven't got around to proposing a PR yet. :)
from nodewebkit.
Is this the .zip
file or the .tar.gz
? I guess it's the .zip
because it currently doesn't apply the mode there. Should fix that. The .tar
and .tar.gz
is already using the mode on the files it extracts (if not defined).
from nodewebkit.
Fixed in kevva/decompress@931ba43.
from nodewebkit.
\o/ Thank you @kevva! You rock!
@adiq Did you want to send a PR for this?
from nodewebkit.
Big thanks to @kevva.
Unfortunately i tried installing with his new fix, and it didn't help at all.
I've tested with 4fbb6ae changes using [email protected] and [email protected].
@shama please take a look at this.
from nodewebkit.
Sorry I should have been more clear. With zip files on OSX you can specify the mode in the external file attributes header. Currently we're using zip which exposes this as entry.getMode()
to get the mode of the file within the zip so when extracted we can use the zip's permissions. See: https://github.com/kriskowal/zip/blob/master/zip.js#L219
I took a look into adm-zip which doesn't appear to support this ability. So for now, I'll just have it manually set the permissions after it extracts on OSX.
Thanks for the help guys! Commits in bound...
from nodewebkit.
Published as v0.8.5-2
. Thanks!
from nodewebkit.
Related Issues (20)
- Installation of v0.9.2 failing on Mac OS X HOT 1
- error when running npm start- maybe a newbe problem HOT 5
- Update to node-webkit v0.10.0-rc1 HOT 2
- JS Allocation failed on travis HOT 3
- Expose absolute path of nodewebkit via node api HOT 9
- npm install fails HOT 1
- Please update to v0.10.1 HOT 1
- nodejs engine HOT 1
- Doesn't install on Windows HOT 4
- Proposed plan to remove complexity in the installer version handling HOT 2
- Issue on debian HOT 3
- Error: Cannot find module 'C:\scripts\install.js' HOT 3
- Suggest edit on README.md HOT 1
- Update to 0.11.0 HOT 5
- Please update to 0.11.2 HOT 1
- Error during installation on Windows 8 x64 HOT 1
- Looks like the next version will be named nwjs HOT 6
- GamePad HOT 6
- Problem while installing slack on windows 10 HOT 1
- Unable to install [email protected] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nodewebkit.