Comments (11)
Hmm I'll take a look. Extracting is quick for me on osx and ubuntu. download uses https://www.npmjs.org/tar and https://www.npmjs.org/zlib for extracting tar files: https://github.com/kevva/decompress/blob/master/index.js#L154
Could you try with those libraries directly and see if it is the extraction or our implementation that is the problem?
from nodewebkit.
I see same problem in Travis build
from nodewebkit.
@3y3 Can you try the above as well and let us know if it is our implementation or zlib/tar?
from nodewebkit.
@shama , I don't have problems on local machine, but Travis CI cloud fails installation at sometime.
How about add travis config to project (I can add pr).
Also I checked one unhandled error event in logs, I'll find it and push pr.
Thanks for project, now we try to use it in node-inspector
from nodewebkit.
Thanks @3y3. I've added the project to travis and will investigate (it is 3mins in and does indeed look slower than it should be). I'll see if I can isolate the issue.
A time it takes to download and separate one for extracting would be nice too.
from nodewebkit.
I'm able to duplicate now on OSX with the linux x64 tar file. I created this repo to isolate the issue: https://github.com/shama/nodewebkit-test
It looks like tar sometimes gets hung up. This might be related to these issues: isaacs/node-tar#23 isaacs/node-tar#22
I'll see if I can find where it gets hung up on there.
from nodewebkit.
Just throwing this out, https://github.com/mafintosh/tar-stream might be a good alternative to try. /cc @kevva
from nodewebkit.
There's also https://github.com/shibukawa/node-ext-tar that uses native tar, might check that out too if it's stable enough. Should be faster.
from nodewebkit.
The upstream issue was resolved on September 16th
from nodewebkit.
Cool, thank @adam-lynch!
from nodewebkit.
and @kevva as I think he is likely responsible for the fix. :D
from nodewebkit.
Related Issues (20)
- Installation of v0.9.2 failing on Mac OS X HOT 1
- error when running npm start- maybe a newbe problem HOT 5
- Update to node-webkit v0.10.0-rc1 HOT 2
- JS Allocation failed on travis HOT 3
- Expose absolute path of nodewebkit via node api HOT 9
- npm install fails HOT 1
- Please update to v0.10.1 HOT 1
- nodejs engine HOT 1
- Doesn't install on Windows HOT 4
- Proposed plan to remove complexity in the installer version handling HOT 2
- Issue on debian HOT 3
- Error: Cannot find module 'C:\scripts\install.js' HOT 3
- Suggest edit on README.md HOT 1
- Update to 0.11.0 HOT 5
- Please update to 0.11.2 HOT 1
- Error during installation on Windows 8 x64 HOT 1
- Looks like the next version will be named nwjs HOT 6
- GamePad HOT 6
- Problem while installing slack on windows 10 HOT 1
- Unable to install [email protected] HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nodewebkit.