Giter VIP home page Giter VIP logo

Comments (11)

shama avatar shama commented on August 16, 2024

Hmm I'll take a look. Extracting is quick for me on osx and ubuntu. download uses https://www.npmjs.org/tar and https://www.npmjs.org/zlib for extracting tar files: https://github.com/kevva/decompress/blob/master/index.js#L154

Could you try with those libraries directly and see if it is the extraction or our implementation that is the problem?

from nodewebkit.

3y3 avatar 3y3 commented on August 16, 2024

I see same problem in Travis build

from nodewebkit.

shama avatar shama commented on August 16, 2024

@3y3 Can you try the above as well and let us know if it is our implementation or zlib/tar?

from nodewebkit.

3y3 avatar 3y3 commented on August 16, 2024

@shama , I don't have problems on local machine, but Travis CI cloud fails installation at sometime.
How about add travis config to project (I can add pr).
Also I checked one unhandled error event in logs, I'll find it and push pr.

Thanks for project, now we try to use it in node-inspector

from nodewebkit.

shama avatar shama commented on August 16, 2024

Thanks @3y3. I've added the project to travis and will investigate (it is 3mins in and does indeed look slower than it should be). I'll see if I can isolate the issue.

A time it takes to download and separate one for extracting would be nice too.

from nodewebkit.

shama avatar shama commented on August 16, 2024

I'm able to duplicate now on OSX with the linux x64 tar file. I created this repo to isolate the issue: https://github.com/shama/nodewebkit-test

It looks like tar sometimes gets hung up. This might be related to these issues: isaacs/node-tar#23 isaacs/node-tar#22

I'll see if I can find where it gets hung up on there.

from nodewebkit.

shama avatar shama commented on August 16, 2024

Just throwing this out, https://github.com/mafintosh/tar-stream might be a good alternative to try. /cc @kevva

from nodewebkit.

kevva avatar kevva commented on August 16, 2024

There's also https://github.com/shibukawa/node-ext-tar that uses native tar, might check that out too if it's stable enough. Should be faster.

from nodewebkit.

adam-lynch avatar adam-lynch commented on August 16, 2024

The upstream issue was resolved on September 16th

from nodewebkit.

shama avatar shama commented on August 16, 2024

Cool, thank @adam-lynch!

from nodewebkit.

shama avatar shama commented on August 16, 2024

and @kevva as I think he is likely responsible for the fix. :D

from nodewebkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.