Comments (13)
shayki5
commented on September 25, 2024
2
Hi @Celimas and @WesselKroos,
For a quick solution, I added top=10000, please update me if it solved the issue :)
from azure-devops-create-pr-task.
tyler-marklyn
commented on September 25, 2024
1
Thanks for your reply! I tried running the rest api, and I think I see the problem. When I call that API I get the first 100 users (alphabetically) in our organization. Unfortunately, our organization has 3100+ users in it, so this only goes partway through the "A" names (it ends in the "Alex"s). I just tested it on a user whose email starts with "ab" and it worked.
From the API documentation here, it looks like the top parameter defaults to 100 and returns only the first 100 users.
In my case, raising top to the maximum (10,000) would solve the issue, but in general it seems like the code that gets this might have to use a loop incrementing the skip parameter until it gets back an empty set.
from azure-devops-create-pr-task.
shayki5
commented on September 25, 2024
Hi @Celimas,
Thank you for reporting that!
Can you try run this rest api (even in your browser) - https://vsaex.dev.azure.com/intentional/_apis/userentitlements?api-version=4.1-preview.1 and check if your email exist in the results?
In the past, is it worked for you? because I did some changes a few days ago.
Thank you!
Shayki
from azure-devops-create-pr-task.
WesselKroos
commented on September 25, 2024
We've got the same issue (I think). I was unable to verify the users list length, becuase I miss the rights to run the rest api in our organisation.
But removing the reviewers in the task fixed the problem for us.
from azure-devops-create-pr-task.
tyler-marklyn
commented on September 25, 2024
@shayki5 the most recent version fixed the issue for me. Thank you!
from azure-devops-create-pr-task.
WesselKroos
commented on September 25, 2024
Sounds good to me. Thanks for the quick fix!
I'll be able to verify this fix in about 2 weeks when we have another release. So feel free to close this issue in the meantime.
from azure-devops-create-pr-task.
shayki5
commented on September 25, 2024
@Celimas - Great, thank you for your update!
@WesselKroos - Please update here if it's solved your error.
from azure-devops-create-pr-task.
WesselKroos
commented on September 25, 2024
@shayki5 We again received the error today.
Here is our event log:
2020-05-15T07:40:54.4235534Z ##[section]Starting: Create Pull Request to master
2020-05-15T07:40:54.4492713Z ==============================================================================
2020-05-15T07:40:54.4493106Z Task : Create Pull Request
2020-05-15T07:40:54.4493557Z Description : Automatically create a Pull Request for Azure DevOps or GitHub repository from Build or Release pipeline, supports also multi target branch.
2020-05-15T07:40:54.4493996Z Version : 1.2.131
2020-05-15T07:40:54.4494212Z Author : Shayki Abramczyk
2020-05-15T07:40:54.4494590Z Help : [More Information](https://github.com/shayki5/azure-devops-create-pr-task/blob/master/README.md)
2020-05-15T07:40:54.4495038Z ==============================================================================
2020-05-15T07:40:57.2003225Z The Source Branch is: refs/heads/release/1.37-rc.6
2020-05-15T07:40:57.2007518Z The Target Branch is: refs/heads/master
2020-05-15T07:40:57.2014454Z The Title is: Finish release/1.37-rc.6 to master
2020-05-15T07:40:57.2021201Z The Description is: Requested from pipeline "Acceptatie & Productie" in Azure DevOps
2020-05-15T07:40:57.2028535Z Is Reviewers are: [email protected]; [email protected]; [email protected]
2020-05-15T07:40:57.2119100Z Is Draft Pull Request: False
2020-05-15T07:40:57.8043895Z 147 new commits! perofrm a Pull Request...
2020-05-15T07:40:58.9915038Z The reviewers are: [email protected] [email protected] [email protected]
2020-05-15T07:40:59.2863351Z {
2020-05-15T07:40:59.2864638Z "sourceRefName": "refs/heads/release/1.37-rc.6",
2020-05-15T07:40:59.2866106Z "title": "Finish release/1.37-rc.6 to master",
2020-05-15T07:40:59.2870663Z "WorkItemRefs": [
2020-05-15T07:40:59.2871272Z {
2020-05-15T07:40:59.2871524Z "id": "55072",
2020-05-15T07:40:59.2871808Z "url": ""
2020-05-15T07:40:59.2872046Z },
2020-05-15T07:40:59.2876081Z {
2020-05-15T07:40:59.2876327Z "id": "56358",
2020-05-15T07:40:59.2876864Z "url": ""
2020-05-15T07:40:59.2877105Z },
2020-05-15T07:40:59.2877320Z {
2020-05-15T07:40:59.2877564Z "id": "59347",
2020-05-15T07:40:59.2877844Z "url": ""
2020-05-15T07:40:59.2878082Z },
2020-05-15T07:40:59.2878294Z {
2020-05-15T07:40:59.2878537Z "id": "59516",
2020-05-15T07:40:59.2878819Z "url": ""
2020-05-15T07:40:59.2879057Z },
2020-05-15T07:40:59.2879270Z {
2020-05-15T07:40:59.2879512Z "id": "60210",
2020-05-15T07:40:59.2879794Z "url": ""
2020-05-15T07:40:59.2880033Z },
2020-05-15T07:40:59.2880259Z {
2020-05-15T07:40:59.2880502Z "id": "58860",
2020-05-15T07:40:59.2880790Z "url": ""
2020-05-15T07:40:59.2881261Z },
2020-05-15T07:40:59.2881550Z {
2020-05-15T07:40:59.2881797Z "id": "60086",
2020-05-15T07:40:59.2882082Z "url": ""
2020-05-15T07:40:59.2882321Z },
2020-05-15T07:40:59.2882537Z {
2020-05-15T07:40:59.2882907Z "id": "58545",
2020-05-15T07:40:59.2883196Z "url": ""
2020-05-15T07:40:59.2883447Z },
2020-05-15T07:40:59.2883645Z {
2020-05-15T07:40:59.2883889Z "id": "57311",
2020-05-15T07:40:59.2884169Z "url": ""
2020-05-15T07:40:59.2884502Z },
2020-05-15T07:40:59.2885739Z {
2020-05-15T07:40:59.2885985Z "id": "59846",
2020-05-15T07:40:59.2886283Z "url": ""
2020-05-15T07:40:59.2886537Z },
2020-05-15T07:40:59.2886736Z {
2020-05-15T07:40:59.2886980Z "id": "59541",
2020-05-15T07:40:59.2887261Z "url": ""
2020-05-15T07:40:59.2887513Z },
2020-05-15T07:40:59.2887710Z {
2020-05-15T07:40:59.2887952Z "id": "56759",
2020-05-15T07:40:59.2888233Z "url": ""
2020-05-15T07:40:59.2888573Z },
2020-05-15T07:40:59.2888785Z {
2020-05-15T07:40:59.2889028Z "id": "59832",
2020-05-15T07:40:59.2889308Z "url": ""
2020-05-15T07:40:59.2889608Z },
2020-05-15T07:40:59.2889826Z {
2020-05-15T07:40:59.2890076Z "id": "59759",
2020-05-15T07:40:59.2890358Z "url": ""
2020-05-15T07:40:59.2890611Z },
2020-05-15T07:40:59.2890810Z {
2020-05-15T07:40:59.2891052Z "id": "56203",
2020-05-15T07:40:59.2891335Z "url": ""
2020-05-15T07:40:59.2891585Z },
2020-05-15T07:40:59.2891784Z {
2020-05-15T07:40:59.2892026Z "id": "56351",
2020-05-15T07:40:59.2892310Z "url": ""
2020-05-15T07:40:59.2892563Z },
2020-05-15T07:40:59.2892760Z {
2020-05-15T07:40:59.2893005Z "id": "59662",
2020-05-15T07:40:59.2893287Z "url": ""
2020-05-15T07:40:59.2893547Z },
2020-05-15T07:40:59.2893744Z {
2020-05-15T07:40:59.2894116Z "id": "57478",
2020-05-15T07:40:59.2894399Z "url": ""
2020-05-15T07:40:59.2894651Z },
2020-05-15T07:40:59.2894849Z {
2020-05-15T07:40:59.2895093Z "id": "55534",
2020-05-15T07:40:59.2895375Z "url": ""
2020-05-15T07:40:59.2895626Z },
2020-05-15T07:40:59.2895824Z {
2020-05-15T07:40:59.2896066Z "id": "59286",
2020-05-15T07:40:59.2896347Z "url": ""
2020-05-15T07:40:59.2896600Z },
2020-05-15T07:40:59.2896796Z {
2020-05-15T07:40:59.2897040Z "id": "57515",
2020-05-15T07:40:59.2897322Z "url": ""
2020-05-15T07:40:59.2897584Z },
2020-05-15T07:40:59.2897781Z {
2020-05-15T07:40:59.2898032Z "id": "58353",
2020-05-15T07:40:59.2898328Z "url": ""
2020-05-15T07:40:59.2898566Z },
2020-05-15T07:40:59.2898763Z {
2020-05-15T07:40:59.2899005Z "id": "58799",
2020-05-15T07:40:59.2899479Z "url": ""
2020-05-15T07:40:59.2899762Z },
2020-05-15T07:40:59.2899963Z {
2020-05-15T07:40:59.2900233Z "id": "55274",
2020-05-15T07:40:59.2900515Z "url": ""
2020-05-15T07:40:59.2900753Z },
2020-05-15T07:40:59.2900951Z {
2020-05-15T07:40:59.2901209Z "id": "58859",
2020-05-15T07:40:59.2901489Z "url": ""
2020-05-15T07:40:59.2902155Z },
2020-05-15T07:40:59.2932130Z {
2020-05-15T07:40:59.2932526Z "id": "59125",
2020-05-15T07:40:59.2932817Z "url": ""
2020-05-15T07:40:59.2933056Z },
2020-05-15T07:40:59.2933254Z {
2020-05-15T07:40:59.2933513Z "id": "58879",
2020-05-15T07:40:59.2933795Z "url": ""
2020-05-15T07:40:59.2934031Z },
2020-05-15T07:40:59.2934231Z {
2020-05-15T07:40:59.2934489Z "id": "58798",
2020-05-15T07:40:59.2934772Z "url": ""
2020-05-15T07:40:59.2935008Z },
2020-05-15T07:40:59.2935206Z {
2020-05-15T07:40:59.2935462Z "id": "54137",
2020-05-15T07:40:59.2935744Z "url": ""
2020-05-15T07:40:59.2935992Z },
2020-05-15T07:40:59.2936197Z {
2020-05-15T07:40:59.2936456Z "id": "57513",
2020-05-15T07:40:59.2936737Z "url": ""
2020-05-15T07:40:59.2936973Z },
2020-05-15T07:40:59.2937171Z {
2020-05-15T07:40:59.2937428Z "id": "57514",
2020-05-15T07:40:59.2937710Z "url": ""
2020-05-15T07:40:59.2937946Z },
2020-05-15T07:40:59.2938144Z {
2020-05-15T07:40:59.2938403Z "id": "57519",
2020-05-15T07:40:59.2938686Z "url": ""
2020-05-15T07:40:59.2938921Z },
2020-05-15T07:40:59.2939117Z {
2020-05-15T07:40:59.2939375Z "id": "57525",
2020-05-15T07:40:59.2939663Z "url": ""
2020-05-15T07:40:59.2939897Z }
2020-05-15T07:40:59.2940622Z ],
2020-05-15T07:40:59.2940956Z "description": "Requested from pipeline \"Acceptatie \u0026 Productie\" in Azure DevOps",
2020-05-15T07:40:59.2941620Z "reviewers": [
2020-05-15T07:40:59.2941818Z {
2020-05-15T07:40:59.2942105Z "id": "xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx",
2020-05-15T07:40:59.2942473Z "isRequired": "false"
2020-05-15T07:40:59.2942722Z },
2020-05-15T07:40:59.2942909Z {
2020-05-15T07:40:59.2943132Z "id": "",
2020-05-15T07:40:59.2943434Z "isRequired": "false"
2020-05-15T07:40:59.2943683Z },
2020-05-15T07:40:59.2943990Z {
2020-05-15T07:40:59.2944216Z "id": "",
2020-05-15T07:40:59.2944534Z "isRequired": "false"
2020-05-15T07:40:59.2944781Z }
2020-05-15T07:40:59.2944970Z ],
2020-05-15T07:40:59.2945163Z "isDraft": "False",
2020-05-15T07:40:59.2946089Z "targetRefName": "refs/heads/master"
2020-05-15T07:40:59.2946489Z }
2020-05-15T07:40:59.9334400Z ##[error]{"$id":"1","innerException":null,"message":"Invalid argument value.\r\nParameter name: The identity is not recognized.","typeName":"Microsoft.TeamFoundation.SourceControl.WebServer.InvalidArgumentValueException, Microsoft.TeamFoundation.SourceControl.WebServer","typeKey":"InvalidArgumentValueException","errorCode":0,"eventId":0}
2020-05-15T07:40:59.9627466Z ##[section]Finishing: Create Pull Request to master
from azure-devops-create-pr-task.
shayki5
commented on September 25, 2024
Hi,
I made some changes to the reviewers section, can you share the task configuration? (YAML or screenshot from the old UI pipelines).
Are all the reviewers are users or also have teams?
Thank you!
from azure-devops-create-pr-task.
WesselKroos
commented on September 25, 2024
Hi,
I made some changes to the reviewers section, can you share the task configuration? (YAML or screenshot from the old UI pipelines).
Sure, here you go:
steps:
- task: ShaykiAbramczyk.CreatePullRequest.CreatePullRequest.CreatePullRequest@1
displayName: 'Create Pull Request to master'
inputs:
sourceBranch: '$(ReleaseBranch)'
targetBranch: master
title: 'Finish $(ReleaseBranch) to master'
description: 'Requested from pipeline "$(Release.DefinitionName)" in Azure DevOps'
reviewers: '[email protected]; [email protected]; [email protected]'
autoComplete: true
deleteSourch: true
Are all the reviewers are users or also have teams?
Yes, one of the users is me and the other 2 users have the same access levels as me in the project and are of the type "aad user" in the permissions settings of the project.
from azure-devops-create-pr-task.
shayki5
commented on September 25, 2024
@WesselKroos Thanks!
Please try without spaces between the reviewers:
reviewers: '[email protected];[email protected];[email protected]'
from azure-devops-create-pr-task.
WesselKroos
commented on September 25, 2024
@WesselKroos Thanks!
Please try without spaces between the reviewers:
reviewers: '[email protected];[email protected];[email protected]'
@shayki5 Spaces between the reviewers was indeed the problem. Thanks for the fix!
from azure-devops-create-pr-task.
shayki5
commented on September 25, 2024
@WesselKroos Great :)
You're welcome!
from azure-devops-create-pr-task.
Related Issues (20)
- Does not work under Linux x64 agent HOT 1
- Running Task in self-managed agent behind a Proxy HOT 6
- Getting 403 Forbidden in the CreatePullRequestTask HOT 1
- Set the creator of the PR to the author of the commit instead of the Build Service User HOT 2
- Wildcard support in targetBranch HOT 7
- Create PR by other user than "project collection build service" HOT 9
- Running on Azure windows-latest agent pool still task is failing HOT 2
- Enhancement - Add work item via ID/URL HOT 1
- Getting error The underlying connection was closed: Could not establish trust relationship for the SSL/TLS secure channel HOT 13
- Automatically complete PR HOT 1
- 400 Bad Request to bypass PR policies HOT 4
- Feature request: add support for git tags
- Is "deleteSourch" a typo? HOT 1
- Version 1.2.363 breaks pipeline for branch with forward slash HOT 3
- Can't set Auto Complete to PR HOT 2
- Error (404) Not Found when adding reviewers on my PR (Azure DevOps) HOT 6
- alwaysCreatePr does not work HOT 1
- Use original git commit message as description (ADO) HOT 6
- Can't check "Delete Source Branch" when using "Bypass Policies" HOT 4
- Autocomplete option not working HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from azure-devops-create-pr-task.