Giter VIP home page Giter VIP logo

Comments (25)

evilash1987 avatar evilash1987 commented on July 28, 2024

Update: It appears to be just this particular set of 100 mods causing issue. Other merges work just fine loading. I will try to see if I can narrow down which mod is causing this

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

Update 2: I think I narrowed one issue down to the mod Extra Variants: The Master Collection (Updated for 2.2)

If the mod loads without merging, it works fine.
If a merge is made consisting of only this mod, it works fine.
If a merge is made consisting of this mod and at least one other, crash.

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

Update 3: Okay, I can't seem to find any particular rhyme or reason to what is happening. I just went through my load order merging 5 at a time and it loaded fine. Merged the first 35 together (same mods, just packaged as 1 vs as 7 merges) and it only loaded when loading the packs of 5 but the 35-mod merge does not load. It is very odd I have been using this mod manager for a while and never had this issue until now.

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

Update 4: I think I got it. Apparently I need to reverse sort by pack name when making the merge otherwise it will merge in reverse sort order which then causes many problems for submods.

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

that's really, really helpful, thanks a lot
see if https://github.com/Shazbot/WH3-Mod-Manager/releases/tag/v1.28.3 fixes it

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

So what is the fix you mention? How does that affect generating merges?

EDIT: I cannot seem to even create a workable merge now. Previously I simply reverse-sorted the Pack column in the Merge window and it woold generate and load correctly. I made a merge of the whole list that way. (I have 210 mods, merged into 1). I am going to revert to 1.28.2 to see if that was still working for me today)

EDIT2: I also just notice the context-menu options for Merges are not in the menu in 1.28.3. I.e. you cannot delete or re-merge them.

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

it does some pre-sorting to change the order of files inside the merged pack

see if restarting the app gives you back the context-menu options

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

the context menu issue is fixed in v1.28.4, there was a timing issue since the new merging process takes much longer

from wh3-mod-manager.

mdlomn avatar mdlomn commented on July 28, 2024

With v1.28.4 I'm getting a crash no matter which mods I chose to merge. I even tried merging only two mods which I know merged successfully previously. If I activate any newly merged mods the game crashes on startup (in the first loadscreen)

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

what are those 2 mods? if you have them enabled try disabling them

from wh3-mod-manager.

mdlomn avatar mdlomn commented on July 28, 2024

Looks like it was an issue on my end. When I created the new merge patch it included another set of mods I had tried to merge before. I tried merging them again today and had no issues. Sorry about the false alarm

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

Sorry for delay did not have a lot of time to look into this lately. In the very latest 1.30.1 (as of this writing), I cannot make a merge patch that works. As before I am still able to make one in v1.28.2. I ask that you just give us the option to create a merge from the mods "Order" column (from the main table). This merge would combine mods by starting at the highest order (i.e. lowest in the list) and descending (ascending the list but descending order), since that is how the game assigns priority.

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

I confess the more I use the mod merging feature that I don't believe the issue to simply be related to the order mods are merged. It appears to be an issue with how merged files are made in general. It appears that made combinations of merged mods just will not load.

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

I agree, that's why the old way isn't the correct way and the system needs to be automatic. If you can find a small mod combination that crashes I can examine it but otherwise it'd be too hard to examine. The mod combinations I tried testing with worked fine.

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

@Shazbot I am surprised you cannot find any combination, as it happens quite a bit for me in any substantial mod. For instance a mod list of two items,

Combination of Mod Configuration Tool and Warband Upgrade Ultimate

2853239091|2815354316

They work as individual mods.
Merged mod of the two crashes.

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

I can start an Immortal Empires Empire campaign fine with a merged mod with those 2

wh3mm_6wvQ0zx5co

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

Yeah, mine did too when I did it again. I must have ran afoul of something still being selected from a previous merge? I did it again though...

image

Runs if I uncheck merge but not with merge.

EDIT: Add mod list ids -> 2869979154|2841939065|2856936614

from wh3-mod-manager.

mdlomn avatar mdlomn commented on July 28, 2024

I think I had this problem too. Essentially when you merge any mods you selected will be included in any future merge during that same session. So if you have a merge mod that doesn't work (i.e. crashing on startup) and you try merging a different set of mods without restarting the manager and deleting the previous merge mod you won't see that the original set of merged mods are included in your new merge

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

@mdlomn That doesn't explain the new error I mentioned though.

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

wh3mm_uyg5ClGrCJ

this one works fine for me

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

@mdlomn that's a very nice catch, thanks

should be fixed in v1.30.3

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

@Shazbot

Doesn't work for me! Literally selected those three mods as enabled. Closed the mod manager. Opened it back up. Merged the three mods (did nothing but click Merge Mods, then Merge). Enabled the merged mod. Closed the mod manager. Opened it back up. Pressed play. Game startup plays but hangs/crashes before main menu.

EDIT: Misspoke a bit for click Merge Mods, then Merge. I had to select the 3 mods first then click Merge.

from wh3-mod-manager.

Shazbot avatar Shazbot commented on July 28, 2024

MD5 hash of my merged pack is C825AB4BC85E71778BE946148B6ED793, you can compare it to your merged pack, they should be the same

I used OpenHashTab but you can also calculate the hash with powershell and other ways

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

image

It matches but still doesn't load. I have no idea why

from wh3-mod-manager.

evilash1987 avatar evilash1987 commented on July 28, 2024

Well now that is interesting! I opened the merge file in RPFM and (re)saved it as-is and now it loads!

from wh3-mod-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.