Giter VIP home page Giter VIP logo

Comments (6)

fiuzagr avatar fiuzagr commented on May 14, 2024 1

Install the [email protected] solved for me.

npm install [email protected] --save-dev

from prettier-standard.

sheerun avatar sheerun commented on May 14, 2024 1

Sorry for the trouble, it's good that rxjs decided to revert backward incompatibility

from prettier-standard.

matthewdordal avatar matthewdordal commented on May 14, 2024

I had this same issue and had to install [email protected] as a devDependency. My node version is 8.9.1

> [email protected] format /Users/matthewdordal/sites/redux-history-push-middleware
> npx prettier-standard 'src/**/*.js'

Cannot read property 'Observable' of undefined
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] format: `npx prettier-standard 'src/**/*.js'`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the [email protected] format script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/matthewdordal/.npm/_logs/2017-12-05T04_18_46_383Z-debug.log

from prettier-standard.

okuryu avatar okuryu commented on May 14, 2024

This seems to be a regression of rxjs. I verified it resolved following fixes for prettier-standard, but rxjs's fixes might coming soon. See also ReactiveX/rxjs#3155 (comment)

diff --git a/package.json b/package.json
index 3cf2fd0..9310ca8 100644
--- a/package.json
+++ b/package.json
@@ -35,7 +35,7 @@
     "messageformat": "^1.0.2",
     "prettier": "1.7.x",
     "prettier-eslint": "^8.1.1",
-    "rxjs": "^5.4.0"
+    "rxjs": "^5.5.3"
   },
   "devDependencies": {
     "babel-cli": "^6.24.1",
diff --git a/src/format-files.js b/src/format-files.js
index eefc135..a576ee0 100644
--- a/src/format-files.js
+++ b/src/format-files.js
@@ -2,7 +2,7 @@
 import path from 'path'
 import fs from 'fs'
 import glob from 'glob'
-import Rx from 'rxjs/Rx'
+import * as Rx from 'rxjs/Rx'
 import format from 'prettier-eslint'
 import chalk from 'chalk'
 import getStdin from 'get-stdin'

from prettier-standard.

dan-gamble avatar dan-gamble commented on May 14, 2024

Weirdly enough, even when doing @fiuzagr's suggestion of npm install [email protected] --save-dev on yarn (yarn add -D [email protected]) it doesn't work but when doing it on npm it does 👍

from prettier-standard.

okuryu avatar okuryu commented on May 14, 2024

[email protected] has been released. This issue looks resolved now.

from prettier-standard.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.