Hi thanks for the lib! It seems that it panics under some scenarios. <p dir="auto"

Program seems to panic when dropping vectors about allo-isolate HOT 1 CLOSED

fzyzcjy commented on August 20, 2024

Program seems to panic when dropping vectors

from allo-isolate.

Comments (1)

shekohex commented on August 20, 2024 1

Another way, is to take into account a null ptr when the vec is empty before we go and dealloc it:

allo-isolate/src/ffi.rs

Lines 184 to 191 in 0ae80ab

 fn visit<T: DartTypedDataTypeTrait>(&self) { 

 let _ = unsafe { 

 Vec::from_raw_parts( 

 self.0.values as *mut T, 

 self.0.length as usize, 

 self.0.length as usize, 

 ) 

 };

You can see from the following frames:

10: <<allo_isolate::ffi::DartCObject as core::ops::drop::Drop>::drop::MyVisitor as allo_isolate::into_dart::DartTypedDataTypeVisitor>::visit
             at ./src/ffi.rs:186:29
  11: allo_isolate::into_dart::visit_dart_typed_data_type
             at ./src/into_dart.rs:268:35

from allo-isolate.

Related Issues (19)

Custom types from library result in: `Cell<bool>` cannot be shared between threads safely HOT 2
Passing structs through an isolate.post() HOT 2
The official website, Sunshine.foundation, says that domain is being sold... HOT 3
bug: DartCObject does not handle cases except Int8/Uint8, making memory leak HOT 2
bug: Memory leak using Dart_PostCObject because need to consider the return value is true or false HOT 4
bug: critical DOUBLE-FREE problem for all calls to post() HOT 4
How is the library tested? (I cannot run it via Valgrind + real Dart) HOT 5
Directly find out Dart_PostCObject function pointer, instead of manually letting Dart to call Rust's store_dart_post_cobject? HOT 2
Publish a new version? HOT 4
Support `Float32List`? (Can make a PR) HOT 5
Streaming data HOT 3
Sanitizer errors HOT 6
Support Vec<Box<XXX>>
Implicit zero copy on `Vec<u8>` HOT 9
when zero-copy is enabled, shall we mark `ZeroCopyBuffer` as deprecated, and provide a NonZeroCopyBuffer HOT 6
Is memory copy involved when sending `Uint8List` from Dart to Rust? HOT 2
Is there any way to run a Rust function on Dart VM shutdown? HOT 2
bug: Cannot use allo-isolate in two libraries with static linking because of symbol name duplication HOT 4

Program seems to panic when dropping vectors about allo-isolate HOT 1 CLOSED

Comments (1)

Related Issues (19)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	fn visit<T: DartTypedDataTypeTrait>(&self) {
	let _ = unsafe {
	Vec::from_raw_parts(
	self.0.values as *mut T,
	self.0.length as usize,
	self.0.length as usize,
	)
	};