When parsing <div class="highlight highlight-source-js notranslate position-relati

I think that the issue is on this line: <a href="https://github.com/shellscape/postcss

With this patch it gets it correct but for the outermost one: <div class="highligh

Fixed in <a class="commit-link" data-hovercard-type="commit" data-hovercard-url="https

Nested function calls have ) token in the wrong place about postcss-values-parser HOT 4 CLOSED

vjeux commented on August 18, 2024

Nested function calls have ) token in the wrong place

from postcss-values-parser.

Comments (4)

vjeux commented on August 18, 2024

I think that the issue is on this line: https://github.com/shellscape/postcss-values-parser/blob/master/lib/parser.js#L265-L271 it requires a stack instead of a single value.

from postcss-values-parser.

vjeux commented on August 18, 2024

With this patch it gets it correct but for the outermost one:

--- a/lib/parser.js
+++ b/lib/parser.js
@@ -29,6 +29,7 @@ module.exports = class Parser {
   constructor (input, options) {
     const defaults = { loose: false };

+    this.stack = [];
     this.input = input;
     this.options = Object.assign({}, defaults, options);
     this.position = 0;
@@ -266,7 +267,7 @@ module.exports = class Parser {

     if (last && last.type === 'func' && last.unbalanced < 0) {
       last.unbalanced = 0; // ok we're ready to add parens now
-      this.cache = this.current;
+      this.stack.push(this.current);
       this.current = last;
     }

@@ -355,9 +356,8 @@ module.exports = class Parser {
       this.error('Expected opening parenthesis', token);
     }

-    if (!this.current.unbalanced && this.cache) {
-      this.current = this.cache;
-      this.cache = null;
+    if (!this.current.unbalanced && this.stack.length) {
+      this.current = this.stack.pop();
     }
   }

Root {
  type: 'root',
  nodes:
   [ Value {
       type: 'value',
       nodes:
        [ FunctionNode {
            type: 'func',
            value: 'a',
            nodes:
             [ Parenthesis { type: 'paren', value: '(' },
               FunctionNode {
                 type: 'func',
                 value: 'b',
                 nodes:
                  [ Parenthesis { type: 'paren', value: '(' },
                    FunctionNode {
                      type: 'func',
                      value: 'c',
                      nodes:
                       [ Parenthesis { type: 'paren', value: '(' },
                         FunctionNode {
                           type: 'func',
                           value: 'd',
                           nodes:
                            [ Parenthesis { type: 'paren', value: '(' },
                              Parenthesis { type: 'paren', value: ')' } ] },
                         Parenthesis { type: 'paren', value: ')' } ] },
                    Parenthesis { type: 'paren', value: ')' },
                    Parenthesis { type: 'paren', value: ')' } ] } ] } ] } ] }