Exception thrown on float duration values about postcss-values-parser HOT 9 CLOSED

I'd be happy to give this a try. Would it bu useful to append something like this to the test array and expand the regex until it doesn't fail?

    '-5deg',
    '5deg',
    '5.5deg',
    '-5.5deg',
    '.5deg',
    '-.5deg',

from postcss-values-parser.

Indeed it should. Thanks for the heads up @glen-84 !

from postcss-values-parser.

Ah, s as a unit. Can you link to the spec for other valid time-units?

from postcss-values-parser.

• Level 2 https://www.w3.org/TR/CSS2/aural.html#times
• Level 3 https://drafts.csswg.org/css-values-3/#time
• Level 4 https://drafts.csswg.org/css-values-4/#time

Basically s and ms are allowed values. Level 2 defines that values may not be negative, but that note has disappeared from Level 3 onwards.

MDN provides examples with negative values, so might be useful to take that into consideration as well

from postcss-values-parser.

Any time sheet when this issue will be fixed?
Should be compatible with https://drafts.csswg.org/css-values-4/#numeric-types right?
So just unitRegexp should be updated or is it necessary to make bigger changes?
https://github.com/shellscape/postcss-values-parser/blob/master/lib/nodes/Numeric.js#L17

from postcss-values-parser.

@radeno that's probably what needs to be updated, and tests will need to be added as well. I would happily review a pull request for this.

from postcss-values-parser.

@bartveneman i tried to add angle values, but when 90deg was set then test fails. I don't have time to dig deeper. But time values support waits in PR.

from postcss-values-parser.

Ah, sorry, I missed that reference above 😬

from postcss-values-parser.

@shellscape Should this be closed? (by #87)

from postcss-values-parser.