Negative and positive numbers parsed as two tokens about postcss-values-parser HOT 8 CLOSED

thanks for the report. would gladly review a PR to resolve this.

from postcss-values-parser.

I tried! I couldn’t get my head around the parser. 😟

from postcss-values-parser.

this week is a little nutty for me, so I may not get to a fix until the weekend.

from postcss-values-parser.

tracked down the bit of the spec that pertains to this. https://drafts.csswg.org/css-values-3/#calc-syntax. in the future, please do that legwork if you're quoting the spec. I'll see about applying these rules.

from postcss-values-parser.

Sorry, I should have linked it! For reference, it's also in the syntax module under <number-token>.

from postcss-values-parser.

no worries. I'm refactoring the whole thing at the moment to do away with babel, so it'll be a bit until that's done, and then I can tackle the two +/- issues. fwiw, the tokenizer is where the issue is and that's just one big while loop.

from postcss-values-parser.

I got that far, I couldn’t figure out how to get wordEnd and wordEndNum to co-operate. Do you have a branch for the refactor?

from postcss-values-parser.

Yeah I literally just pushed it :) https://github.com/lesshint/postcss-values-parser/blob/es6-refactor/test/number.js are the new tests I've added.

here's where the bit that looks around an operator now lives https://github.com/lesshint/postcss-values-parser/blob/es6-refactor/lib/tokenize.js#L197 that should fix the issue. I've started throwing TokenizeError for things that shouldn't pass validation. and I've been using https://jigsaw.w3.org/css-validator/validator to double check the validation, along with the spec.

from postcss-values-parser.