kcov support broken with --execdir about shellspec HOT 6 CLOSED

Hi @mh21,
I suspect this has to do with the way your project folder is structured.

From the documentation:

This is the typical directory structure. Version 0.28.0 allows many of these to be changed by specifying options, supporting a more flexible directory structure.

<PROJECT-ROOT> directory
├─ .shellspec                       [mandatory]
├─ .shellspec-local                 [optional] Ignore from version control
├─ .shellspec-quick.log             [optional] Ignore from version control
├─ report/                          [optional] Ignore from version control
├─ coverage/                        [optional] Ignore from version control
│
├─ bin/
│   ├─ your_script1.sh
│              :
├─ lib/
│   ├─ your_library1.sh
│              :
│
├─ spec/ (also <HELPERDIR>)
│   ├─ spec_helper.sh               [recommended]
│   ├─ banner[.md]                  [optional]
│   ├─ support/                     [optional]
│   │
│   ├─ bin/
│   │   ├─ your_script1_spec.sh
│   │             :
│   ├─ lib/
│   │   ├─ your_library1_spec.sh

As you can see, the spec directory should be under the <PROJECT-ROOT> directory, whereas yours is inside the bin (in your case program1) folder.
What you did is NOT a workaround, you just used the correct folder structure. 😃

Typically i use this structure:

<PROJECT-ROOT> directory
├─ spec/
│   ├─ test.spec.sh
├─ src/
│   ├─ mycode.sh
├─ .shellspec
├─ README.md

Solution n.1

If what you're trying topull off is a monorepo continue doing as you did in your "workaround".

Each new folder containing a new sub-project (i.e. program1) should have its own .shellspec file.

Solution n.2 (couldn't test)

If you really really need the original project structure (with only one .shellspec file at the top) try to explicitly pass the test folder to shellspec:

shellspec --kcov program1/spec/

from shellspec.

Just for some context, this is from https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests. It is a repository of kernel tests used by Red Hat kernel QE. Different directories are different kernel tests, and having the spec directory (for testing the tests 🙈) next to the actual kernel tests makes a lot of sense for the QE folks that are individually only concerned with a subset of the kernel tests directories.

from shellspec.

Just for some context, this is from https://gitlab.com/redhat/centos-stream/tests/kernel/kernel-tests. It is a repository of kernel tests used by Red Hat kernel QE. Different directories are different kernel tests, and having the spec directory (for testing the tests 🙈) next to the actual kernel tests makes a lot of sense for the QE folks that are individually only concerned with a subset of the kernel tests directories.

WHAT?

Red Hat uses shellspec???

This is news to me!

However... How did you manage to use kcov?
I couldn't reproduce the bug since i can't install it 😞

Did you build it from source?

I'm using Windows 10 with WSL2.

from shellspec.

We started to use it in the CKI team (https://cki-project.org) which takes care of the Red Hat kernel CI infrastucture. And we are really really happy with it 🤗.

Examples: https://gitlab.com/cki-project/pipeline-definition/-/tree/main/spec

We run kcov in a Fedora Core container, e.g. via registry.gitlab.com/cki-project/cki-tools/cki-tools:production (which has shellspec/kcov already installed, https://gitlab.com/cki-project/containers/-/blob/main/includes/snippet-shellspec is what gets pulled into our Dockerfiles). My WSL2 skills are pretty rusty, so I'm not sure about the current way to run containers there 🙈.

from shellspec.

Thank you for your explanation! I'll close this issue, as it seems to be a problem on our end 🙈.

from shellspec.

Thank you for your explanation! I'll close this issue, as it seems to be a problem on our end 🙈.

Happy you were able to solve😄

What was the problem (if could be useful)?

from shellspec.