Giter VIP home page Giter VIP logo

Comments (3)

SherClockHolmes avatar SherClockHolmes commented on August 20, 2024 1

@JRaspass @andrewtet Thanks for digging into the issue for me. I should have time for implementing this over the weekend.

from webpush-go.

ptman avatar ptman commented on August 20, 2024 1

For some reason RecordSize: 3070 didn't work for me with firefox android. I got a response back saying: "Final composed message payload too long for recipient: 4170 bytes. Please try a shorter message." No idea why that was larger than the limit set

RecordSize: 2048 seems to have worked

from webpush-go.

andrewtet avatar andrewtet commented on August 20, 2024

@JRaspass running into the same issues and I was actually going to write up an issue about this last night. Seems like the issue is with the maxRecordLength and the pad function. The maxRecordLength in webpush-go is hard coded to 4096 and we pad every message to that length for security reasons, but for Firefox Mobile the max content length is 3070.

There's a PHP library for webpush that had similar issues and allows for a custom max content size to be passed in. @SherClockHolmes would you be okay with that solution?

PHP lib issue: web-push-libs/web-push-php#62

PHP lib documentation of max content sizeL: https://github.com/web-push-libs/web-push-php#how-can-i-disable-or-customize-automatic-padding

P.S. It's been a while, but hope all is well @SherClockHolmes. This lib is great BTW

from webpush-go.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.