Comments (8)
I have already done something pretty similar to the first one (only difference is that the user would have to type "sherlock user123 --tag 1337" for the input you mentioned) and the same functionality (ignoring all sites were tag isnt required). I was waiting for a member of sherlock to respond before opening a pr for that solution. Would you mind working on the second proposal you gave, so that the team could choose between the two?
Am terribly sorry for the inconvenience, and you can also continue working on the same solution as well.
from sherlock.
Yeah, sure, not a problem, even if your solution gets accepted first, I don't mind. Still having fun here
from sherlock.
Working on it, but using a "#" as a placeholder for a name tag is probably not a good idea since some URLs might already have this symbol. I think it's better to use "<>" or a second "{}".
I'm trying to add a new property when adding a website, something like a boolean variable "isTagRequired", and if set to True, user would be prompted to add a tag after the username, for example "sherlock user123#1337"
from sherlock.
from sherlock.
Working on it, but using a "#" as a placeholder for a name tag is probably not a good idea since some URLs might already have this symbol. I think it's better to use "<>" or a second "{}". I'm trying to add a new property when adding a website, something like a boolean variable "isTagRequired", and if set to True, user would be prompted to add a tag after the username, for example "sherlock user123#1337"
I have been working on it as well. Your recommendation about # makes sense to me, I proposed it since it would be intuitive and would make the code more readable. Asking the user to add a tag would only make sense to me if he was using the --site optional argument which specifies which site to search for.
from sherlock.
Asking the user to add a tag would only make sense to me if he was using the --site optional argument which specifies which site to search for.
You're right, so I see 2 options:
- Only search for a username with tag in websites where isTagRequired is set to True; e.g. "sherlock user123#1337 --tag" would only check websites with isTagRequired. Otherwise "sherlock user123#1337" would work the same way it's been working till now.
- Dynamically check for a "#" symbol in the username arg, so if you enter "sherlock user123#1337", the tag would be detected automatically without using the "--tag" flag. Then proceed to only check the websites with isTagRequired.
Right now I'm proceeding with the 1st option, but it will be easy to change later
from sherlock.
Note that --tag
/--tags
is also being discussed for use as in #2088
from sherlock.
I have already created a PR, #2169
from sherlock.
Related Issues (20)
- Only run GitHub action if it is actually needed
- False positive for: babyRU HOT 3
- False positive for: Fiverr HOT 1
- Run error but could be user error HOT 5
- Latest pull 0.14.4 exits with error. HOT 2
- zsh: no matches found: test{?}test HOT 1
- Master branch CI should also trigger on rc branches
- Dockerfile reliant upon requirements.txt and local build HOT 4
- Add test for build Docker images on merge/push to master/rc
- Permission denied HOT 2
- Check if Sherlock is package or script at runtime
- Add target debug flag
- Return schema specification to manifest HOT 1
- Remove torrequest dependency HOT 2
- Requesting support for: After all, how to add Instagram or Facebook to the Sherlock dataset? HOT 1
- Adopt sqlite with proper caching HOT 3
- ImportError: attempted relative import with no known parent package HOT 3
- ModuleNotFoundError in Vercel production
- Improved single source of truth for versioning
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sherlock.