Giter VIP home page Giter VIP logo

Comments (4)

sunnyque avatar sunnyque commented on June 9, 2024

Do you bootstrap Modal for app (bootstrap(App, [... ROUTER_PROVIDERS .. Modal)? Also it must be included in App Component providers: [... Modal], There must be no trouble of using modal from service but sure you missed something

from ngx-modialog.

zarkosusnjar avatar zarkosusnjar commented on June 9, 2024

Yes, f course i tried to provide those in bootstrap:

  provide(ModalConfig, {useValue: new ModalConfig('lg', true, 81)}),
  provide(Modal, {useValue : Modal }),
  provide(ElementRef, {useValue: ElementRef}), //needed because of: EXCEPTION: No provider for ElementRef! (Newsletters -> ModalService -> ElementRef)

But when I clear DI excpetions, and try to call service after click on a button:

openDialog(e: any) {
    this._modalService.openDialog('large');
  }

I get this:

EXCEPTION: Error during evaluation of "click"
...
 ORIGINAL EXCEPTION: TypeError: this.modal.open is not a function

I must be missing something...

from ngx-modialog.

zarkosusnjar avatar zarkosusnjar commented on June 9, 2024

Got it, basically I needed to put Modal and ElementRef without provide function. Now it works when provided like this:

...
provide(ModalConfig, {useValue: new ModalConfig('lg', true, 81)}),
  Modal,
  ElementRef,
  ModalService
...

Example service would be very helpful in demo. I guess everyone who makes SPA will make this as service instead of duplicating dozens of lines of code in each component they need modal in.

from ngx-modialog.

rsnider19 avatar rsnider19 commented on June 9, 2024

@zarkosusnjar can you post your working modal service?

from ngx-modialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.