Giter VIP home page Giter VIP logo

Comments (3)

 avatar commented on June 9, 2024 1

I don't know what's going on. That doesn't work for me. DOM imported from angular2/src/platform/dom/dom_adapter is always null, even though the makeCurrent function is running. It must be something to do with module resolution in my project. Although it seems odd to me that you would be able to reassign an exported reference (the DOM global) at all. (Disclaimer: I'm new to this stuff.)

Best guess is that the exported variable is somehow associated with an import/module path, and maybe it's exported in more than one place, so there is possibly more than one reference to it, only one of which is being updated by setRootDomAdapter? In that case it could be related to issue #40.

This code, right above the bootstrap call, prints 'DOM: null'.

BrowserDomAdapter.makeCurrent();
import {DOM} from 'angular2/src/platform/dom/dom_adapter';
console.log('DOM:', DOM);

The best I can do seems to be to instantiate my own BrowserDomAdapter and use it instead of this DOM global.

from ngx-modialog.

shlomiassaf avatar shlomiassaf commented on June 9, 2024

Strange, you can look at the demo, or even batter at the code generator and you will see it works there.

I'm not happy with the DOM adapter direct use, it's a temp workaround to support adding a class to the body.

from ngx-modialog.

shlomiassaf avatar shlomiassaf commented on June 9, 2024

BTW, if you want DOM to be the current DOM adapter
call BrowserDomAdapter.makeCurrent(); before bootstrapping, this is the right way.

from ngx-modialog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.