Comments (4)
I can take a look at this tomorrow π
from dawn.
We have something like this in narrative:
from dawn.
One thing to note is that Narrative is displayed differently when it comes to showing the variant image: video demonstration
From the video demonstration above, the variant image changes on the first image, but the rest of the product images are still being displayed at the bottom.
If we want to apply similar pattern on Dawn, we could change the 1st image when we switch variants, however, the rest of the images will still be displayed underneath.
If we switch variant, show the selected variant image and hide the rest of the product images, I don't think it will be good for performance because we're triggering layout shift.
This will need some UX exploration.
from dawn.
If we switch variant, show the selected variant image and hide the rest of the product images, I don't think it will be good for performance because we're triggering layout shift.
To be clear on expected behaviour:
When this setting is enabled, and I select a variant I should see:
- First, the image associated with the variant
- Then, the images not associated to any variant.
- However, I should not see the images associated to the other variants.
So we would not be hiding the rest of the images, but a portion of it. You may be right that we'll need to figure out a way that is performant.
from dawn.
Related Issues (20)
- [Quick Order List] message `x items added/removed` not showing
- category metafields not available through search & discovery HOT 2
- /cart/change.js don't return Checkout Validation Rule error like /cart/add.js
- [Quick order list] resize error when the header isn't set to be sticky
- Dawn 15 Update rendering incorrect product data in JsonLD schema. HOT 4
- [Footer] Newsletter sign up form, no error message when trying to sign up if you already have a customer record HOT 1
- Predictive search removes special charcters in suggested search terms HOT 1
- Swatch colors not working HOT 1
- Quick Order List enhancement| Renaming βeachβ translation key to βeach_htmlβ, and all its usages in the liquid code.
- Filters animation silently fails
- The button link when hovering is different from the button link in the customize.
- Photos problems with variant option
- Twitter card does not work with x.com URLs
- Allow minus button in Cart to remove items for items with minimum quantity restrictions
- Sale badge does not appear if there is a variant with a 0 compare_at_price
- Critical errors on global.js script in old browser (<=2021) caused by `#` usage for private fields on `SectionId` class
- Country/region selector's search query gets displayed in other search input
- Shopify Subscription App error on Dawn theme 15.0.2 HOT 2
- Menu conditional on market
- Syne font extra bold: wide characters (M and W) are cut off in Safari
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dawn.