Giter VIP home page Giter VIP logo

Comments (4)

ludoboludo avatar ludoboludo commented on August 28, 2024 2

I can take a look at this tomorrow πŸ‘

from dawn.

nicklepine avatar nicklepine commented on August 28, 2024

We have something like this in narrative:
image

from dawn.

tauthomas01 avatar tauthomas01 commented on August 28, 2024

One thing to note is that Narrative is displayed differently when it comes to showing the variant image: video demonstration

From the video demonstration above, the variant image changes on the first image, but the rest of the product images are still being displayed at the bottom.

If we want to apply similar pattern on Dawn, we could change the 1st image when we switch variants, however, the rest of the images will still be displayed underneath.

If we switch variant, show the selected variant image and hide the rest of the product images, I don't think it will be good for performance because we're triggering layout shift.

This will need some UX exploration.

from dawn.

nicklepine avatar nicklepine commented on August 28, 2024

If we switch variant, show the selected variant image and hide the rest of the product images, I don't think it will be good for performance because we're triggering layout shift.

To be clear on expected behaviour:

When this setting is enabled, and I select a variant I should see:

  1. First, the image associated with the variant
  2. Then, the images not associated to any variant.
  3. However, I should not see the images associated to the other variants.

So we would not be hiding the rest of the images, but a portion of it. You may be right that we'll need to figure out a way that is performant.

from dawn.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.