Giter VIP home page Giter VIP logo

Comments (13)

DBA avatar DBA commented on August 20, 2024

Hello bensie,

The reasoning behind the update was the same as with the remaining of the gemspec: update it and make it current. 1.3.1 was largely outdated.

RubyGems 1.3.7 has been out since May (http://rubyforge.org/frs/shownotes.php?release_id=43601). Didn't know Heroku was not supporting it yet :/

For the time being I've updated my repo: http://github.com/GnomesLab/liquid/tree/v2.2.4

Please note that pulling from there will also pull the comment shorthand syntax (v2.2.3)

{# comment #}

Sorry for any inconvenience this may have caused you,
DBA

from liquid.

bensie avatar bensie commented on August 20, 2024

I'm well aware that 1.3.7 has been around for awhile and am not generally against the idea of updating, but in a minor point release it's definitely unexpected. I'll stick with 2.2.0 for now.

from liquid.

AlekSi avatar AlekSi commented on August 20, 2024

@bensie 2.2.1 works too.

from liquid.

DBA avatar DBA commented on August 20, 2024

2.2.1 does not include the Literal Tag in the gemspec, reason for which the gemspec has been rewritten.

Unfortunately I was not aware of Heroku's incompatibility when I rewritten the gemspec. I would advise the use of the following versions:

  • 2.0.0 (RubyGems 1.3.1+) if you want to be safe on Heroku
  • 2.2.4,in my repo, (RubyGems 1.3.6+) if you want to make use of Literal tag and the Comment shorthand syntax

Best regards,
DBA

from liquid.

bensie avatar bensie commented on August 20, 2024

2.2.1 is has a bad gemspec so it's missing files. Doesn't work at all.

from liquid.

DBA avatar DBA commented on August 20, 2024

Rails 3 is currently requiring 1.3.6, in line with 2.2.4, in my repo.

from liquid.

bhavinjavia avatar bhavinjavia commented on August 20, 2024

Hi DBA,
Thanks for creating 2.2.4 with the fix for Rubygems version. But, I am facing a weird issue on Ubuntu 10.04. I have explained the details in this gist -> http://gist.github.com/591283. Please let me know what are my options now.

from liquid.

DBA avatar DBA commented on August 20, 2024

Hello, could you check if this version solves that issue?

http://github.com/GnomesLab/liquid/commits/v2.2.5.beta

Best regards,
DBA

from liquid.

bhavinjavia avatar bhavinjavia commented on August 20, 2024

Thanks DBA,
Tried 2.2.5beta but it gives the same error. The problem is with the line above the new "require 'liquid/document' " that was added in 2.2.5.beta.
For now, I have locked in Liquid to v2.2.0. It might be good to get a fix for this issue though. Or you might wanna wait till some other Ubuntu guy reports this issue.

from liquid.

DBA avatar DBA commented on August 20, 2024

maybe you could fork 2-2-stable in my repo and submit the changes of a working version so I can test and try and figure out what's going on :)

from liquid.

DBA avatar DBA commented on August 20, 2024

Hello again, could you give my master branch a try? It now uses autoload, which should fix some of those issues.

In order to test you can point your gemfile to: git://github.com/GnomesLab/liquid.git

from liquid.

arvicco avatar arvicco commented on August 20, 2024

Liquid requiring RubyGems >= 1.3.7 makes any gem depending on it unusable under current JRuby (1.5.6):

$ gem install jekyll
ERROR: Error installing jekyll:
liquid requires RubyGems version >= 1.3.7. Try 'gem update --system' to update RubyGems itself.

from liquid.

conatus avatar conatus commented on August 20, 2024

This seems to be still an issue.

from liquid.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.