Comments (6)
betelgeuse
commented on August 20, 2024
1
@fw42 it is a big win for localized projects for languages that have their alphabet outside ASCII.
from liquid.
DBA
commented on August 20, 2024
This would have to be tested by other users in order to ensure that no problems emerge from such change.
from liquid.
fw42
commented on August 20, 2024
Can you please test if this is still an issue with the current Liquid version?
from liquid.
boourns
commented on August 20, 2024
@fw42 I think we ended up merging a PR that fixed this, but I recently reverted it due to the performance impact of a more general regex:
from liquid.
fw42
commented on August 20, 2024
Ok. I don't think being able to use UTF-8 in variable names, etc. is a big win anyways. Closing for now.
from liquid.
fw42
commented on August 20, 2024
@betelgeuse: I agree that it's a nice-to-have and I'm totally up for reviewing any proposed solutions to this that claims to not have a performance impact.
from liquid.
Related Issues (20)
- How to remove Tab space with strip or strip_newlines? HOT 3
- Ruby 3.3 deprecation warnings: base64, bigdecimal will no longer be part of the default gems HOT 1
- Why doesn't parse_json take effect? HOT 1
- Fix Wiki reference
- Custom Liquid::Drop that is called for every missing variable HOT 1
- Possible to get full object & variable name with `strict_variables: true`?
- video_tag fully disable poster HOT 2
- Expose Liquid::Condition in public API
- alt attribute not set for media.preview_image with image_tag filter HOT 1
- Running rake example throws error
- Liquid rendering is unexpectedly changing the "context" attribute on non-Drop classes
- Liquid shopify skórki
- Add WISMOlabs to "Who uses Liquid?" wiki section
- App Block Missing Data On Theme Previews When Proceeded by a Hidden Section Containing an @app Block
- Sort orders by 'created_at' in paginate?
- Regarding deprecation of the total_discount
- Add limit to split filter, like split method in Ruby
- Liquid - Product Description Null Check Not Working
- Should strip_newlines also 'strip' LSEP ?
- Case statement evaluation renders multiple when conditions if a value is repeated
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from liquid.