Add truncate html filter about liquid HOT 9 CLOSED

I have to agree with this one wholehartedly. An addition it would be nice if {% highlighting %} blocks would never be broken up as well.

from liquid.

@dcramer could you elaborate on that? give an example of what this should do exacltly?

from liquid.

I'm guessing the request was for a filter that truncates a string without causing problems with the resulting HTML. For example, truncating <a href="/home">Read more here</a> at 15 characters would result in <a href="/ho... (creating invalid HTML) rather than what was likely intended: <a href="/home">Read more he..., where the visible text is 15 characters (and the length of the HTML code is much longer).

I wrote a filter for my own app that truncates an HTML string, leaving the HTML intact and closing any tags that were opened before the truncation and closed after it (where the closing tags were cut off). Using my example from above, my filter would return <a href="/home">Read more he...</a>.

There's a fair amount of code to accomplish this, but if it's something you guys would like to see added to Liquid itself, I'd be happy to submit a pull request with the code. Otherwise, if this functionality is outside Liquid's scope, I can just post a code sample here.

from liquid.

That sounds useful. Let me check if we already have something like this in Shopify. If not, you can PR.

from liquid.

Ok go ahead Nick, open a pull request, we would be happy to merge this.

from liquid.

Still interested in implementing this, @nickpearson?

from liquid.

Yes, apologies being late on this. I've implemented it and am refining the code a bit before submitting a PR. I guess it can't hurt to submit what I've got for critique. I'll see if I can get that done this week. Thanks for following up.

from liquid.

@nickpearson i think we can close this then?

from liquid.

Yes, let's close it. I haven't had the time to address all the issues @fw42 pointed out in my PR. If I get a chance to improve my code I'll submit another one.

from liquid.