Incorrect case statement in providers/mount.rb about chef-gluster HOT 6 CLOSED

What version of the cookbook are you using?

Integration tests show this is working correctly

         File "/etc/fstab"
           should be file
           content
             should match /^gluster2:\/gv0 \/mnt\/gv0 glusterfs defaults,_netdev,backupvolfile-server=gluster1 0 0$/

from chef-gluster.

I am using 5.0.2 as well.

I am not sure why the current code passed testing but it should not have worked because of how the "===" method is evaluated for class. Please search for "ruby class in case statement" in your favourite search engine for detail.

from chef-gluster.

What are you putting in for backup_server? and what does /etc/fstab show?

from chef-gluster.

I have tried both

    backup_server "backup1"
    backup_server ["backup1", "backup2"]

With either case, I always ended with just the default mount_option: "defaults,_netdev". So to debug this behaviour I added a fallback else statement to mount.rb

def mount_options_for_backup_server
  case new_resource.backup_server.class
  when String
    ',backupvolfile-server=' + new_resource.backup_server
  when Array
    ',backupvolfile-server=' + new_resource.backup_server.join(',backupvolfile-server=')
  else
    Chef::Log.info "backup_server has unknown class? [" + new_resource.backup_server.class.name + "]"
  end

The case statement always fell through, even thought the class is shown correctly as "String" or "Array" in the log output. After further research I found that the object itself should be in the case statement, not object.class, eg

def mount_options_for_backup_server
  case new_resource.backup_server
  when String

It works for me once I made this change.

from chef-gluster.

Hmm i see what you mean with respect to classes in case statements on http://blog.honeybadger.io/rubys-case-statement-advanced-techniques/
However, if thats true, then integration tests should be failing

from chef-gluster.

Solved by #72

from chef-gluster.