Export two functions about zxcvbn-rs HOT 3 CLOSED

This would be a good case for optional parameters in Rust. 🙂 But since those don't exist, I don't think there's a clear, objective benefit to changing the function.

from zxcvbn-rs.

I'm not sure that I agree that this would be cleaner. I feel that having one exported function makes the interface and its options obvious straight away, and makes it easy to switch between having user inputs or not (by having an empty slice).

from zxcvbn-rs.

I can see your reasoning as well. My thinking was, what would a user that didn't know the library well expect the following statement to do:

let password_quality = zxcvbn("password", &[]);

I would expect the first parameter to be the password to be tested, and be right. However, I wouldn't know the meaning of the second parameter without looking at the documentation. This means I'd have to read up on it to understand the code even if I didn't use the parameter myself. Separating the functions mitigates this, and it has the additional advantage of conveying the meaning of the second parameter if I do want to use it.

Anyway, it's not a big thing, so if you disagree I'm fine with closing the issue.

from zxcvbn-rs.