Matrix support for pysh.legendre.pl... about shtools HOT 3 OPEN

It would be great to validate all the input parameters. I've tried to do this as much as possible with the various classes that we define, but the routine you are referring to is a fortran function that is called from python. That doesn't mean that its not possible to do, its just a little more complicated and would probably involve writing some kind of decorator that is applied to the wrapped function.

If anyone wants to try doing this, that would be great! The first step would probably first come up with a generic approach that works with all the various legendre function routines, as the parameters are all the same.

from shtools.

e.g. possibly something of the style of the following for now.

if not isinstance(z, (np.floating, float)):
        raise TypeError(
            "z must be a float type")
            )            

from shtools.

Thank you @MarkWieczorek! I can only think of specific fixes (e.g. check length once passed to fortran) but this is less generic than an ideal solution.

For anyone who finds this issue in the future:

• this 'user bug' is simple to identify in hindsight (user input mistake of entering an array vs a float and expecting a matrix return rather than an array) but it can masquerade as a downstream calculation error (e.g. why is my code not predicting the right value?). Hope that saves some time for folks! :)

from shtools.