Comments (3)
Thanks for the issue report @cjwagner, and for providing the details.
This issue is already on my radar, as PR #24 was sent to address a similar need. See discussion there for some background and #24 (comment) for latest status. The details you're provided in the issue should help find a viable resolution.
I'd prefer to think about this and discuss it in the issue first. Once we have agreement on a resolution plan, implementing the fix will be the easier part.
from graphql.
Here is an example: Something went wrong while executing your query. This may be the result of a timeout, or it could be a GitHub bug. Please include 'EA06:8FDC:2D9BD3C:56E05DD:599AFE05' when reporting this issue.
The solution shouldn't be specific to the format or contents of the response body though since this is just an example from GitHub. The %q
format token is more appropriate than %s
or "%s"
here as it will clearly indicate the start and end of the contents by escaping any "
s.
from graphql.
Ok, I think adding a ReadAll
on the response body and including it in the error text is a reasonable first step to make, for now. Let's do that.
we are seeing lots of 502 and 403 errors that should include explanations in the response bodies.
I'm not sure whether to use %s or %q to format the response body. @cjwagner, would you be able to share sample response bodies during those errors, if you have them available?
A bigger step might be to create a struct error type with a ResponseBody []byte
field in it, but I'd rather defer that until it's really needed.
I've sent PR #30, we can discuss the details there.
from graphql.
Related Issues (20)
- query with circular dependencies leads to infinite recursion HOT 1
- Any interest in native go type support? HOT 1
- I want to add where condition in the query structure, how to do this
- How to define struct HOT 3
- Query and Mutation methods ignore query content when it's wrapped in an interface HOT 3
- Query for Github Projects in an organization HOT 2
- How to deal with integer overflow when using variables HOT 2
- How to make one condition in filter optional? HOT 1
- My stacks
- Question: How to implement an enumeration type HOT 1
- Question: Example of doing pagination (especially on nested resources that are paginated) HOT 6
- Nested struct tag not applied to query HOT 2
- Using alternative rest clients
- OAuth2 Bearer Token with Customer HttpClient HOT 1
- Please make "constructQuery" exported HOT 3
- Allow building mutations from maps instead of structs
- I love this library but it seems unmaintained? HOT 1
- FaunaDB graphql _id defined as _ID not exported HOT 4
- Message: x-hasura-admin-secret but not found,
- Return more verbose error to the caller HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql.