Comments (7)
Thanks for reporting this, I will investigate.
I don't see you doing anything wrong, so if the issue is valid, I suspect it's a bug in the code.
from graphql.
Produces query with errors (no commas between query parameters):
This part might be intentional. My intention was to produce a minified query. When I tested against GitHub's GraphQL server, it accepted comma-less query parameters without issues.
See the following test-case:
Lines 163 to 168 in 671b933
Can you tell me what you're basing the statement that omitting commas is an error on? Is it because it looks wrong, or is it failing to work? If the latter, how can I reproduce it?
Of course, our best bet is to look into the GraphQL spec to see whether omitting commas is considered valid or not.
from graphql.
http://facebook.github.io/graphql/October2016/#sec-Insignificant-Commas and http://facebook.github.io/graphql/October2016/#sec-List-Value seem to suggest that omitting commas is indeed a valid thing to do:
Similar to white space and line terminators, commas (,) are used to improve the legibility of source text and separate lexical tokens but are otherwise syntactically and semantically insignificant within GraphQL query documents.
Commas are optional throughout GraphQL so trailing commas are allowed and repeated commas do not represent missing values.
from graphql.
It produces query with errors too (variable type should be
$someids:[ID!]!
with bang in the end):query($someids:[ID!]){nameStringsByUuid(uuids:[$someids]){inputId}}
That part seems to be a legitimate issue. Basically, I hadn't run into that situation yet, so the code that handles it was left incomplete.
from graphql.
@alexander-myltsev, please see PR #7, it resolves this issue.
from graphql.
@shurcooL works for me now.
from graphql.
Thanks for testing, and for reporting this issue! I'll merge the PR now.
from graphql.
Related Issues (20)
- query with circular dependencies leads to infinite recursion HOT 1
- Any interest in native go type support? HOT 1
- I want to add where condition in the query structure, how to do this
- How to define struct HOT 3
- Query and Mutation methods ignore query content when it's wrapped in an interface HOT 3
- Query for Github Projects in an organization HOT 2
- How to deal with integer overflow when using variables HOT 2
- "Variable \\\"$evar\\\" is never used. HOT 2
- [Feature reqeust] Add possiblity to load query from string / .gql file HOT 4
- Question: How to implement an enumeration type HOT 1
- Question: Example of doing pagination (especially on nested resources that are paginated) HOT 6
- Nested struct tag not applied to query HOT 2
- Using alternative rest clients
- OAuth2 Bearer Token with Customer HttpClient HOT 1
- Please make "constructQuery" exported HOT 3
- Allow building mutations from maps instead of structs
- I love this library but it seems unmaintained? HOT 1
- FaunaDB graphql _id defined as _ID not exported HOT 4
- Message: x-hasura-admin-secret but not found,
- Return more verbose error to the caller HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from graphql.