Comments (3)
sidju
commented on August 25, 2024
It is because you are connecting them directly when their main branches are out of sync. Try it after checking out the tag for the add-ed version used by hired.
I have refactored add-ed to add the last features and am improving the testing (slowly, in the tmp branch) before I make a release of it.
If you'd like you can update your fork of hired to work with the latest add-ed, it should just be to:
- use Buffer instead of VecBuffer (same code, but now as an object instead of a trait implementor)
- construct LocalIO (handles shell escape and file interactions) in the same way as Buffer and handing it into the Ed constructor
- add the lock_ui and unlock_ui funtions to hired's UI, see ClassicUI's implementations in add-ed. (they don't need to do anything special, but it would be nice it they printed exclamation mark on their own line to match GNU Ed's behaviour)
If you do you are welcome to make a PR that I can merge when I have made the add-ed release.
…-------- Original Message --------
On 23 Feb 2023, 06:26, Corallus Caninus wrote:
in hired, trying to reference a local clone of add-ed results in there being no feature named vecbuffer.
steps to reproduce error:
- clone hired
- clone add-ed
- set add-ed in hired's Cargo.toml to local add-ed e.g.: path="../add-ed"
- cargo build
I tried removing the feature from hired in Cargo.toml and explicitly setting it in add-ed but still cant find VecBuffer in hired. patch notes suggest feature is implicit but it cannot be found when removing the feature flag despite versioning being the same in remote and local add-ed.
—
Reply to this email directly, [view it on GitHub](#5), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/ADKYNB6LXIEQJHJWMQCNM4TWY3YHTANCNFSM6AAAAAAVFFNAVI).
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
from add-ed.
Corallus-Caninus
commented on August 25, 2024
I believe the binary didn't get updated when crates.io was updated.
a workspace may help with dependency issues.
https://doc.rust-lang.org/book/ch14-03-cargo-workspaces.html
from add-ed.
sidju
commented on August 25, 2024
add-ed and hired are intentionally out of sync, since I am still verifying the functionality on add-ed after a major refactor and don't wish to prioritize updating hired to use the new API before I am sure add-ed is functional. This isn't a mistake, it is a choice that enables the master branches of both add-ed and hired to build during this API change.
I know of cargo workspaces and have used them before, but my intent isn't to couple hired that tightly to add-ed.
from add-ed.
Related Issues (15)
- Separate w and W handling HOT 1
- 'g', 'G', 'v', 'V' commands behave unpredictably when nested HOT 1
- Can't save empty file
- Undo messages HOT 1
- Consider string normalisation HOT 3
- "/" command input reaches codepath that should be unreachable HOT 2
- `+a` appends after `selection.0 + 1` rather than `selection.1 + 1` as expected
- Moving with tags behaved oddly
- Undo behaviour HOT 3
- Add a tutorial to the end of the longer help text HOT 1
- Doesn't error before OS system call when saving to empty path
- `i` to start inserting HOT 5
- Adding inserting variants for 'm', 't', 'r',etc. HOT 3
- Adding multi-buffer support HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from add-ed.