Giter VIP home page Giter VIP logo

Comments (2)

dlorenc avatar dlorenc commented on July 3, 2024

Plus one on encouraging documents, -1 on a wide range policy like this. Issues are great but aren't necessary and don't always add value.

My refrain on all of this is going to be just trusting people to use their judgment and do the best thing for the project.

from community.

jku avatar jku commented on July 3, 2024

I propose that all PRs should have an attached issue. This can be enforced with a bot.

I'm a big fan of well written issues but I disagree with both of these for two reasons:

  • there's a long tail of minor contributions where this requirement is unneeded friction (my first contribution to this repo was fixing a broken URL in a README: would I have done that contribution if the threat of "this PR must have an issue" had actually been enforced? 🤷)
  • requiring the existence of an issue does not mean there is any valuable information in that issue

I think you cannot create a culture of quality by adding this type of enforcement mechanisms on the org level: for individual projects enforcement may make sense but even then the culture requires committed maintainers first, enforcement just ensures no slipping up from that commitment.

If there are useful metrics in this area that can be calculated, then a yearly review might be something the org could do instead: Have a look at "project quality/health proxy metrics" for all projects, take action if any important projects are lagging behind or trending negatively.

from community.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.