Use chrome.exe that is bundled with node_modules/puppeteer about bible-karaoke HOT 8 CLOSED

We need to test BK on a machine that doesn't have Chrome installed. Or at least installed normally.

from bible-karaoke.

For the error message if someone doesn't have Chrome installed, I'd suggest something like
"Error: You must install Google Chrome" and give a link to the Chrome download page (if that's allowed)
or "Please install Google Chrome in order to use Bible Karaoke software" and give a link to the download page
or something like that.

from bible-karaoke.

confirmed that current version of BK doesn't work if the user doesn't have chrome installed. This issue is about making BK function with the version of chrome.exe that is already delivered with puppeteer. Bonus points if there is some way to use chrome.exe that is shipped with Electron (not sure if that's even possible because I couldn't locate it).

On my windows machine, chrome.exe delivered with puppeteer is located here:
C:\Users\Chris\AppData\Local\Programs\bible-karaoke\resources\app.asar.unpacked\node_modules\puppeteer.local-chromium\win64-706915\chrome-win\chrome.exe

from bible-karaoke.

@irahopkinson Could I request your help? I'm still not able to perform Windows builds. Can you try out the branch feature/useEmbeddedChromium and let me know whether or not it resolves this issue?

from bible-karaoke.

I have been working to get a Win10 VM up and working. Just succeeded in installing BK 0.3.1 with no Chrome installed and got the expected "could not fine Chrome" error.

Now I will build and install from your branch...

from bible-karaoke.

I built your branch @echu888 and ran into a different problem related to the logger which I will post in Slack.

from bible-karaoke.

We should check if there is any effect on the size of the binary after this change.

from bible-karaoke.

Information regarding using puppeteer with the browser bundled with electron

from bible-karaoke.