Giter VIP home page Giter VIP logo

Comments (4)

frankvollebregt avatar frankvollebregt commented on August 16, 2024 1

The documentation page about testing does specify that you need to download the binaries yourself https://drift.simonbinder.eu/docs/testing/ but it also doesn't provide any guidance on a minimum version

from drift.

simolus3 avatar simolus3 commented on August 16, 2024 1

It's extremely reasonable for Drift to rely on SQLite features from 2019. It'd be good for that to be explicit, though.

At the moment we don't have an official minimal sqlite3 version we support for package:sqlite3 and drift's tooling. I think it would be great to pick a stable minimum version (and run tests against that as well). Since tests are currently running against either a fixed sqlite3 or the one shipping with the GitHub Actions Ubuntu runner, I can't reliably say which sqlite3 version is the lowest we can support.

I completely agree about having a clear error message as well, in this case I simply didn't consider that the database option may not have always been available - another thing that would be caught by tests.

from drift.

gnprice avatar gnprice commented on August 16, 2024

It looks like this is probably caused by my having an old version of libsqlite3.so. The relevant SQLite feature looks to have been introduced in 3.29.0:
https://www.sqlite.org/changes.html#version_3_29_0

which is fairly old, from 2019. My local libsqlite3.so is a bit older than that, 3.27.2.

It's extremely reasonable for Drift to rely on SQLite features from 2019. It'd be good for that to be explicit, though.

Is there a minimum SQLite version documented somewhere? I'm not immediately finding one. Possibly https://drift.simonbinder.eu/docs/platforms/#desktop is the most relevant spot for that information.

Better yet, it would be great to get a clear error message to that effect, rather than a traceback when a particular operation that Drift tries to do turns out not to be supported.

from drift.

gnprice avatar gnprice commented on August 16, 2024

Sounds great — thank you!

from drift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.