Comments (4)
I agree with @dickermoshe about the linter, and moving to step-by-step migration is easy.
For now, my point is that when we see the onUpgrade function here, we tend to use the same way to write the migration code. So I suggest making it obvious that this way it discouraged.
Also it would be nice if we state in General tips something like 'Be careful when using the manual migration, don't let the code calls alterTable
twice on the same table or alterTable
then addColumn
If you see that this will be taken care of and there is no need to let this issue open, feel free to close it :)
from drift.
I've updated the docs in f74c5fa to position the tools more prominently and to point out this footgun in particular.
from drift.
We're in middle of a complete docs refresh.
The new docs will do a better job of explaining how migrations should be done.
However we already warn how step-by-step migrations are a requirement to write a working migrations.
Drift makes is very easy to test and verify migrations.
It would be easier to build an automatic migration system than to build a linter that could figure out if the migrations are being done incorrectly.
Moving to step-by-step migrations is quite simple.
If you feel this is a reasonable position, close the issue. I won't close it myself, I don't like telling people their issues aren't important.
from drift.
A downside of step by step migrations is that users may still run into this problem with their existing migrations not covered by tests/step-by-step migrations.
I'll add a warning box to the main migration page strongly suggesting the use of these tools. With the rewrite we should probably just highlight the tools as the default way to do things and mention manual setups as a fallback.
from drift.
Related Issues (20)
- Name Clashing to use `Value`
- Please allow @TableIndex to be used on mixins HOT 2
- Don't generate tables for abstract class derivatives of Table HOT 3
- App Binary size extremly expanded after upgrade drfit HOT 2
- Having two "autoincrement" integers breaks the insert Companion HOT 1
- Error: The argument type 'Object?' can't be assigned to the parameter type 'Expression<int>' HOT 3
- DateTimeColumn values are always returned as local time, timezone/UTC gets lost HOT 6
- Generation Errors When Using 'Address' As Table Name HOT 1
- Got UI stuck when writting data to SQL HOT 7
- Allow using `getApplicationSupportDirectory` instead of `getApplicationDocumentsDirectory` in drift_flutter HOT 1
- Ability to declare interfaces for data classes HOT 2
- Build error when using package:web v1.0.0 HOT 3
- [BUG] Web 1.0 support, Flutter 3.24.0 support HOT 1
- Prefer using dart:js_interop instead of package:js HOT 2
- Re-Release Docs Site HOT 1
- Ability to disable "auto include" of table class declarations, daos, .drift files, etc HOT 2
- Migrations 2.7 => 2.19, unlogic errors HOT 2
- Facing an issue in production app HOT 1
- Generator table discovery should exclude private classes HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from drift.