Giter VIP home page Giter VIP logo

Comments (4)

HasanAlqaisi avatar HasanAlqaisi commented on August 16, 2024 2

I agree with @dickermoshe about the linter, and moving to step-by-step migration is easy.

For now, my point is that when we see the onUpgrade function here, we tend to use the same way to write the migration code. So I suggest making it obvious that this way it discouraged.

Also it would be nice if we state in General tips something like 'Be careful when using the manual migration, don't let the code calls alterTable twice on the same table or  alterTable then addColumn

If you see that this will be taken care of and there is no need to let this issue open, feel free to close it :)

from drift.

simolus3 avatar simolus3 commented on August 16, 2024 2

I've updated the docs in f74c5fa to position the tools more prominently and to point out this footgun in particular.

from drift.

dickermoshe avatar dickermoshe commented on August 16, 2024

We're in middle of a complete docs refresh.
The new docs will do a better job of explaining how migrations should be done.

However we already warn how step-by-step migrations are a requirement to write a working migrations.

Drift makes is very easy to test and verify migrations.
It would be easier to build an automatic migration system than to build a linter that could figure out if the migrations are being done incorrectly.

Moving to step-by-step migrations is quite simple.

If you feel this is a reasonable position, close the issue. I won't close it myself, I don't like telling people their issues aren't important.

from drift.

simolus3 avatar simolus3 commented on August 16, 2024

A downside of step by step migrations is that users may still run into this problem with their existing migrations not covered by tests/step-by-step migrations.

I'll add a warning box to the main migration page strongly suggesting the use of these tools. With the rewrite we should probably just highlight the tools as the default way to do things and mention manual setups as a fallback.

from drift.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.