Comments (3)
GitHub is pretty cool in that it scans the text in PRs and comments for phrases like "closes #".
But I can do that for you too :)
from isotp-c.
IIRC this is from a weird Debian-based system with an old compiler suite that needed the option to link correctly.
Feel free to submit a PR making this configurable.
Additionally flagging the target_compile_options as public means they're propagated to dependencies.
This is most definitely an oversight on my end. I hadn't run into any issues with this, so it just got looked over. Again, feel free to create a PR (can be one single PR for these two cases) and I'll merge it.
Thanks for bringing this up! Much appreciated!
Great work on continuing the development of the library btw!
My pleasure, it's been a super useful library with some of my (and my customers') applications :)
from isotp-c.
Thanks for the background!
I figured there was probably a reason.....at the same time found myself googling when might a static library need PIC enabled 🙈.
I've raised #27 - I'm thinking there's a way to reference this issue in the PR, but alas the button alludes me.
from isotp-c.
Related Issues (4)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from isotp-c.