Building a static library unnecessarily forces adoption of PIC (position independent code) about isotp-c HOT 3 CLOSED

GitHub is pretty cool in that it scans the text in PRs and comments for phrases like "closes #".

But I can do that for you too :)

from isotp-c.

IIRC this is from a weird Debian-based system with an old compiler suite that needed the option to link correctly.
Feel free to submit a PR making this configurable.

Additionally flagging the target_compile_options as public means they're propagated to dependencies.

This is most definitely an oversight on my end. I hadn't run into any issues with this, so it just got looked over. Again, feel free to create a PR (can be one single PR for these two cases) and I'll merge it.

Thanks for bringing this up! Much appreciated!

Great work on continuing the development of the library btw!

My pleasure, it's been a super useful library with some of my (and my customers') applications :)

from isotp-c.

Thanks for the background!

I figured there was probably a reason.....at the same time found myself googling when might a static library need PIC enabled 🙈.

I've raised #27 - I'm thinking there's a way to reference this issue in the PR, but alas the button alludes me.

from isotp-c.