Comments (3)
Yes, I understood the purpose of ssrPromises
array, but...
Let's say:
- I deployed application that uses
axios-hooks
(for example on AWS). - I am trying to open my application from my laptop and from smartphone on the same time. So, there are two requests for server.
- Server receiving first request and starting to push promises to
ssrPromises
. - While server processes the first request (not all promises resolved or even
React.renderToString
is still executing), another request is received (it is possible because Node.js is async by the nature and uses non-blocking I/O model) and promises related to second request will be pushed tossrPromises
. - When
await serializeCache()
will be called for the first request, it will be in pending state until all promises (including promises related to second request) will be resolved. - In this
const cache = ...
for the first request will contains some data related to second request.
This is a pretty common issue across React ecosystem. So there is known solution.
For example, https://github.com/nfl/react-helmet suffer from this kind of problem too. I am very surprised that react-helmet
didn't resolved this problem for all years of existing. But there is existing fork that solves problem: https://github.com/staylor/react-helmet-async.
I am trying to say that this lib (axios-hooks
) needs something like what react-helmet-async
do to isolate request contexts.
from axios-hooks.
Oh wow, you have a very good point indeed. I'll think of something, haven't done something like this before but I'm sure there must be a reasonably easy solution. Thanks for reporting!
from axios-hooks.
That's the purpose exactly, if I understand what you mean. This is for SSR, where we need to wait for alla requests to complete before rendering the application on the server.
from axios-hooks.
Related Issues (20)
- Release pending!
- Refetch "expression is not callable" HOT 2
- Why I'm getting 2 rendered using this hook, when component mounts? HOT 9
- Release pending!
- Prevent CanceledError and redundant HTTP calls for identical request data HOT 1
- Support for API polling HOT 1
- type error HOT 9
- Uncaught TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) HOT 1
- How to configure SSR with NextJS? HOT 3
- "Uncaught runtime errors: Cannot read properties of undefined (reading 'data')" after upgrading to CRA 5.0.1 & Node 18 HOT 6
- Not usable within the US? HOT 1
- Error from a dynamically loaded uri HOT 3
- Release pending!
- Release pending!
- useAxios hook sending in 2 requests, the first is cancelled immediately HOT 3
- Release pending! HOT 3
- Release pending!
- Release pending!
- Type error: MouseEvent using refetch and provided example from docs HOT 2
- Still an issue with both `executeGet` and `execute` methods when executed manually HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from axios-hooks.