How should we handle errors on manual requests? about axios-hooks HOT 6 CLOSED

I guess the additional configuration option is one possible way but it doesn't feel like it deserves so much attention at the current time, I would like to keep things simple. If there's demand for this feature I may reconsider it. Thanks for reporting though!

from axios-hooks.

I might just do this

const silenceError = (fn) => () => fn().catch(() => {})

    const [{ data, loading, error }, postLogin] = useAxios({
          url: '/login',
          method: 'POST'
        },
        { manual: true }
    )

    const login = silenceError(() => {
      return postLogin({
        data: {
          username,
          password
        }
      })
    })

from axios-hooks.

Fair point. It's been requested in #51 that the manual fetch function returns the promise, which makes sense to me because if you do a manual fetch you may also want more control about what happens when the promise resolves/rejects. But this also means that if there's a rejection and you're not interested into it you need to swallow it somehow.

Unfortunately I don't see a solution that can cover both cases. Ideas?

from axios-hooks.

I thought it might be a deliberate design choice. It can be quite nice to get the actual promise.

I guess you could pass in another option like this:

          url: '/login',
          method: 'POST'
        },
        { 
            manual: true,
            void: true // or returnPromise: false
         }
    )

There is no need to over complicate this for me, at the moment I am using:

const silenceError = (promise) => promise.catch(() => {})
...
...
...
    const login = () => {
      silenceError(postLogin({
        data: {
          username,
          password
        }
      }))
    }

from axios-hooks.

Or just catch the promise in a standard way....

Thanks again for the library.

from axios-hooks.

What if it throws 400, a bad request, and we want to show the error message to the user? I am having the same issue.

const [{ error }, executeUpdate] = axiosHook(
    {
      ...ApiConfig.COURSE.UPDATE_COURSE,
    },
    { manual: true }
  );

...and here I call executeUpdate. I thought error will be the updated error but that line,if (error) { ...do something },never gets executed as promise is rejected.

  const updateCourse = () => {
    handleSubmit(async (data) => {
      await executeUpdate({
        url: `${ApiConfig.COURSE.GET_COURSES.url}/${courseRow.id}`,
        data,
      });
      console.log(error);  // never gets called
      await refetchCourse();
    })();
  };

Is there a way we could silence the error from executeUpdate and get the error from state error variable instead?

from axios-hooks.