Winetricks does not always create wintricks.log causing re-installs to happen about protonfixes HOT 11 CLOSED

There is a check to see if winetricks was already run in place, but it might not be working on your setup for some reason.
Is there a winetricks.log file in the prefix of the game that it keeps running on? If the winetricks log isn't getting created it will keep trying to install.

from protonfixes.

@simons-public You are correct, for some reason the winetricks.log aren't created from my scripts in localfixes folder.

from protonfixes.

I'll see if I can replicate it on my end and try to find a fix. Can you post a log as well?

from protonfixes.

Sorry for the late reply, here is the log from my current fixscript that im working on.

https://gist.github.com/MrCraigen/67556f2094b3ea78c717b79f0d8ed301

Here is the script
https://gist.github.com/MrCraigen/b0c20209f59f13494c3c9e859350d9be

from protonfixes.

Sorry for the long wait, can you check if there is a winetricks.log file in the GAMEID/pfx folder for the game? And if there is one, can you post the contents? It might be checkinstalled function isn't reading it properly.

from protonfixes.

I tried to find it, but i can't seem to find it. Is there a way to generate it?

from protonfixes.

I reworked the protontricks utility to use the Proton wine instead of system wine. I'm hoping that might have fixed the issue. I just pushed a new version to pypi, can you update and see if you're still having the issue?

EDIT: If it's not fixed, as a temporary workaround you can create a winetricks.log file, it just needs to be a text file with the installed tricks on each line like so:

xact
win7

from protonfixes.

I can reproduce this bug using util.protontricks('vd=1920x1080'), this should simply create and apply a temporary vd.reg file (for setting wine virtual desktop resolution). See $ winetricks settings list for details.

Moreover, I can see a several records for settings in my old winetricks.log files, e.g.

csmt=off
csmt=on

so, even if this bug will be fixed, there is another obvious problem -- such changes will stop work after several attempts.

Maybe better to create and use own log file to track all applied fixes, e.g. protonfixes.log or protontricks.log. And also handle possible settings problem : e.g. vd=... can be changed several times, switching from 1080 to 720 and wise-versa, so protonfixes may require more advanced tracking system to detect this behaviour (simple check/change second part if = detected).

from protonfixes.

@pchome

Maybe better to create and use own log file to track all applied fixes

Or an INI file, protontricks.ini.

from protonfixes.

@pchome Thanks, I realized that util.checkinstalled was checking the winetricks log from top to bottom, when it logs in chronological order. I updated it so it checks from the bottom first, which should fix the issue when multiple winetricks with the same name are logged.

EDIT: I also removed the '--force' option for winetricks, in the case that winetricks.log is being stored somewhere else, this should keep it from reinstalling.

from protonfixes.

Unfortunately winetricks.log don't created for vd=... verbs, but csmt=on and csmt=off are ok.

from protonfixes.