Comments (3)
The bigger problem is that some methods use requests
on their own instead of using _call_salesforce
like the rest of the codebase. #54 also has the same issue.
from simple-salesforce.
@TRII: I might be missing something, but #54 uses self.request
which is an instance of requests.Session
, not requests
directly (unless that's what you're referring to). Is there elsewhere that I'm missing where requests
is used directly? The response handling should be generalized between #54 and Salesforce.restful
though.
There is another issue in that SFType
and Salesforce
don't share sessions, but that's captured in #91.
from simple-salesforce.
I was referring more to mixed use of the requests.Session
instance vs the internal _call_salesforce
wrapper. For consistency's sake, everything should use _call_salesforce
, and _call_salesforce
should use the requests.Session
. If not, there is no reason for _call_salesforce
to exist.
from simple-salesforce.
Related Issues (20)
- how to bulk update custom field in order HOT 1
- Bulk Insert api is not returning the rejected row HOT 1
- No external_id_field in the bulk update method HOT 1
- Create SFType wrapper from string or variable rather than attribute name HOT 1
- Link to official documentation is easy to miss and the badge is broken HOT 1
- Add attachment to the Salesforce record HOT 1
- INVALID_LOGIN when logging into Sandbox HOT 2
- Problem with JWT and My Domain/Enhanced Domains HOT 1
- How can is user Bulk API 2.0 with simple-salesforce? and what version of bulk api is used in the current bulk implementation
- Passing username, password, and token to simple_salesforce from environment variables causes authentication failure HOT 1
- Help Needed - Setting custom Field Permissions HOT 3
- 1.12.5 is not in Pypi HOT 3
- bulk2 delete function not working with records parameter
- Simple-Salesforce not using its own session when instantiating Zeep HOT 1
- bulk2 error inserting csv file utf-8 coded
- Issue with Querying with Simple Saleforce where statement
- Add python 3.12 support HOT 4
- FutureWarning issued when sf_api_query() function from project readme encounters an empty related field value
- Auto-sized batching doesn't creates no batches when only one record
- Question about get_by_custom_id / expected behavior / possible bug HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simple-salesforce.