Giter VIP home page Giter VIP logo

Comments (3)

hello-josh avatar hello-josh commented on May 18, 2024

The bigger problem is that some methods use requests on their own instead of using _call_salesforce like the rest of the codebase. #54 also has the same issue.

from simple-salesforce.

demianbrecht avatar demianbrecht commented on May 18, 2024

@TRII: I might be missing something, but #54 uses self.request which is an instance of requests.Session, not requests directly (unless that's what you're referring to). Is there elsewhere that I'm missing where requests is used directly? The response handling should be generalized between #54 and Salesforce.restful though.

There is another issue in that SFType and Salesforce don't share sessions, but that's captured in #91.

from simple-salesforce.

hello-josh avatar hello-josh commented on May 18, 2024

I was referring more to mixed use of the requests.Session instance vs the internal _call_salesforce wrapper. For consistency's sake, everything should use _call_salesforce, and _call_salesforce should use the requests.Session. If not, there is no reason for _call_salesforce to exist.

from simple-salesforce.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.