Giter VIP home page Giter VIP logo

Comments (7)

caciobanu avatar caciobanu commented on June 8, 2024

We can do this but it will look a little strange having src/Component/MessageBus/src. How about dropping src from each component and just use the top src ? Something like Symfony does.

from simplebus.

caciobanu avatar caciobanu commented on June 8, 2024

Maybe we should do a composer install & unit/functional testing for each component separately ? This will help us drop the composer.json from the main repo and will provide faster feedback for each component. Also it will not required to synchronize composer.json from the main repo with the ones from each component.

from simplebus.

cmodijk avatar cmodijk commented on June 8, 2024

We can do this but it will look a little strange having src/Component/MessageBus/src. How about dropping src from each component and just use the top src ? Something like Symfony does.

Hmm, Yes you are right there src/src seems weird. We could go the way Symfony does it that is true.

Maybe we should do a composer install & unit/functional testing for each component separately ? This will help us drop the composer.json from the main repo and will provide faster feedback for each component. Also it will not required to synchronize composer.json from the main repo with the ones from each component.

@ruudk and i started to try this but the problem then becomes that when you create a pull request that spans multiple packages then it wil install the wrong (latest tagged) version and your pull will fail right?

from simplebus.

caciobanu avatar caciobanu commented on June 8, 2024

Yes, it will fail but it can also be useful to catch api BC.

from simplebus.

cmodijk avatar cmodijk commented on June 8, 2024

Yes, it will fail but it can also be useful to catch api BC.

Yeah, that is true but the thing for me to go for the mono repository is that i need to make all packages compatible in 1 pull request. If we don't then we would need to merge a part of the code (which is the old situation with separate packages). Release that package then run the CI again to verify if that works.

from simplebus.

caciobanu avatar caciobanu commented on June 8, 2024

Can i help with moving all code to from src/Component/MessageBus/src to src/Component/MessageBus/ ? But first, I think that you have to get #30 in.

from simplebus.

cmodijk avatar cmodijk commented on June 8, 2024

We are moving to packages/ in #88

from simplebus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.