Giter VIP home page Giter VIP logo

Comments (8)

cmodijk avatar cmodijk commented on June 9, 2024 1

Sure, if you create a PR for this we can accept it.

from simplebus.

ruudk avatar ruudk commented on June 9, 2024

How does FinishesHandlingMessageBeforeHandlingNext forces the serialized commands? I'm not sure that's right.

from simplebus.

cmodijk avatar cmodijk commented on June 9, 2024

This is expected behaviour, if the command handler fails all commands that it has send should not be executed. It is developed like a transaction as the command handler fails all queries are reverted.

For us we have created a separate bus that does not has this middleware.

from simplebus.

scaytrase avatar scaytrase commented on June 9, 2024

The part of the problem is not even with failing but with successful exectution. Calling $bus->handle($command) we expect that command would be handled after call finishes. For async execution we utilize delayed commands with other async tooling, like rabbitmq or jms job queue bundle.

Currently nested calls to handle leads to situations when different machanisms work in a different flows. I.e we call $bus->handle($command) and then the call $eventDispatcher->dispatch($event). And listeners of this event a running at the point of time when $command is not handled yet (but the nature of the event expects it to be finished), so we have to disable this feature.

from simplebus.

scaytrase avatar scaytrase commented on June 9, 2024

I understand that this is intentional behaviour and it suits most of the users. I just ask to make it configurable (with enabled by default, of course, to keep BC)

from simplebus.

scaytrase avatar scaytrase commented on June 9, 2024

@cmodijk I've introduced the simplest solution in #52

from simplebus.

cmodijk avatar cmodijk commented on June 9, 2024

I'm closing this in favor of #52

from simplebus.

scaytrase avatar scaytrase commented on June 9, 2024

Btw there is no real need to close issues prematurely, as Fixes #xx construction will close it for you upon PR merging. Or leave it open for future if PR would pass the review.

from simplebus.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.