Comments (8)
Sure, if you create a PR for this we can accept it.
from simplebus.
How does FinishesHandlingMessageBeforeHandlingNext
forces the serialized commands? I'm not sure that's right.
from simplebus.
This is expected behaviour, if the command handler fails all commands that it has send should not be executed. It is developed like a transaction as the command handler fails all queries are reverted.
For us we have created a separate bus that does not has this middleware.
from simplebus.
The part of the problem is not even with failing but with successful exectution. Calling $bus->handle($command)
we expect that command would be handled after call finishes. For async execution we utilize delayed commands with other async tooling, like rabbitmq or jms job queue bundle.
Currently nested calls to handle
leads to situations when different machanisms work in a different flows. I.e we call $bus->handle($command)
and then the call $eventDispatcher->dispatch($event)
. And listeners of this event a running at the point of time when $command
is not handled yet (but the nature of the event expects it to be finished), so we have to disable this feature.
from simplebus.
I understand that this is intentional behaviour and it suits most of the users. I just ask to make it configurable (with enabled by default, of course, to keep BC)
from simplebus.
@cmodijk I've introduced the simplest solution in #52
from simplebus.
I'm closing this in favor of #52
from simplebus.
Btw there is no real need to close issues prematurely, as Fixes #xx
construction will close it for you upon PR merging. Or leave it open for future if PR would pass the review.
from simplebus.
Related Issues (20)
- Remove / replace travis-ci build status from README files
- Find alternatieve solution for Doctrine\ORM\Proxy\Proxy removal
- Allow php 8 in SymfonyBridge HOT 5
- TypeError with Doctrine\Common\Persistence\ManagerRegistry HOT 4
- View differences between versions HOT 6
- Are you sure that min stability of SimpleBus/asynchronous-bundle should be dev? HOT 1
- Task: Bump PHPStan level from 8 to 9
- CollectsEventsFromEntities not being called HOT 3
- Support for Symfony 7 HOT 1
- Listener service is not found after upgrading Symfony 4.3.11 -> 4.4.5 HOT 11
- Add support for PHP 8 HOT 3
- Automate split HOT 1
- Remove simple-bus/doctrine-orm-bridge test forks HOT 1
- Remove jms-serializer-bundle-bridge ignore HOT 1
- Remove ocramius/proxy-manager fork HOT 1
- Add PHP-CS-Fixer
- Add PHPStan HOT 1
- Add RectorPHP HOT 1
- Use monorepobuilder merge HOT 2
- Run tests also on the monorepo (this tests everything at once), instead of only per package HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from simplebus.