Comments (4)
If we had a pure hooks system in place I'd agree with you.
But SMF is still a mixed model with hooks and file edits and that can break your site without much hassles by disabling a hook.
If someone (like me from time to time) uses a hook to include the file with the function, and then uses a code edit to call the function when it is needed, disabling the include hook would break the site (or at least the page where the function is called), yes I think I placed some safety measure to avoid this, but the safest measure is to not let people harm with things they don't know (and that said I'm wondering why I'm allowed to code! :P).
Additionally disable a hook is something that nobody should do. Why would you disable a hook? I wouldn't even do it for development (if I want to disable a hook for development I just return the function, it's faster).
Have the option there is nice, but IMHO it should be disabled by default.
Why reports are disabled by default? They are not dangerous, the worst that can happen is a spike in resources usage, but still are disabled.
Why 75% of core features are disabled by default? Because are things that the majority of people will not use on their forums. And that's why I think that disable hooks should be off by default: it's potentially dangerous and it's not necessary to the majority.
from smf.
I must have misread/misunderstood the setting yesterday. I thought you had to enable that setting for integration hooks to even work at all, and that's what I was complaining about. As long as integration hooks will still work out-of-the-box without the user having to do anything, I'm fine with the way things are now. We might just need to make it a bit more clear as to what that setting actually does.
from smf.
Ohh okay! :D
I'm not good with this kind of explanations, feel free to reword it! ;)
There is also the backup text that would need a bit of attention... O:)
from smf.
So 'Disable hooks' is disabled.
Double negatives are never very understandable. :)
from smf.
Related Issues (20)
- 3.0: Interface for background tasks queue HOT 4
- [3.0]: Actions\Admin\Permissions::$permission_groups HOT 1
- [3.0]: Background tasks not running
- [3.0]: TypeError on export profile data
- [3.0]: TypeError on adding new languages HOT 1
- [2.1.4]: Installing mod package fails? but succeeds
- [2.1.4]: Renaming a ban fails with Database Error if name is too long
- [3.0]: Avatar changing HOT 1
- [3.0]: htmlspecialcharsRecursive receives integers HOT 2
- [3.0]: Alert::fetch() $to_fetch is receiving integers HOT 14
- [3.0] Backards compat strict type error HOT 3
- [3.0]: Undefined array key in SMF\Actions\Admin\Permissions
- [3.0]: Problems with loading default language strings when using additional languages HOT 3
- [3.0]: Type of SMF\Actions\Post2::$obj must be SMF\Actions\Post HOT 13
- [3.0]: TypeError on removing topic/message
- [3.0]: Class "SMF_BackgroundTask" not found HOT 2
- [2.1, 3.0]: Wrong position for $context['error_code'] in template HOT 3
- [3.0]: Undefined array key "passwrd1" when changing password HOT 4
- [3.0]: Permissions with the 'never_guest' property still show a checkbox for guests in inline permission forms
- [3.0]: Package Manager dies horribly
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from smf.