Giter VIP home page Giter VIP logo

Comments (4)

emanuele45 avatar emanuele45 commented on May 29, 2024

If we had a pure hooks system in place I'd agree with you.
But SMF is still a mixed model with hooks and file edits and that can break your site without much hassles by disabling a hook.

If someone (like me from time to time) uses a hook to include the file with the function, and then uses a code edit to call the function when it is needed, disabling the include hook would break the site (or at least the page where the function is called), yes I think I placed some safety measure to avoid this, but the safest measure is to not let people harm with things they don't know (and that said I'm wondering why I'm allowed to code! :P).

Additionally disable a hook is something that nobody should do. Why would you disable a hook? I wouldn't even do it for development (if I want to disable a hook for development I just return the function, it's faster).
Have the option there is nice, but IMHO it should be disabled by default.
Why reports are disabled by default? They are not dangerous, the worst that can happen is a spike in resources usage, but still are disabled.
Why 75% of core features are disabled by default? Because are things that the majority of people will not use on their forums. And that's why I think that disable hooks should be off by default: it's potentially dangerous and it's not necessary to the majority.

from smf.

Oldiesmann avatar Oldiesmann commented on May 29, 2024

I must have misread/misunderstood the setting yesterday. I thought you had to enable that setting for integration hooks to even work at all, and that's what I was complaining about. As long as integration hooks will still work out-of-the-box without the user having to do anything, I'm fine with the way things are now. We might just need to make it a bit more clear as to what that setting actually does.

from smf.

emanuele45 avatar emanuele45 commented on May 29, 2024

Ohh okay! :D
I'm not good with this kind of explanations, feel free to reword it! ;)
There is also the backup text that would need a bit of attention... O:)

from smf.

norv avatar norv commented on May 29, 2024

So 'Disable hooks' is disabled.

Double negatives are never very understandable. :)

from smf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.