Got typescript error when using with recently released TS 3.9 and fast-json-stringify about typebox HOT 3 CLOSED

Hi. Since that issue I decided to drop the use of enum in favor of:
enum: Type.Union([Type.Literal('A'), Type.Literal('B')])
Both, serialization and TS types checks works as expected. The generated JSONSchema, on the other hand, differs from enum, but the check is almost the same.

from typebox.

@apyrkh

Apologies for the delay. Are you able to get in touch with the fast-json-stringify guys and get their thoughts on making the enum type property optional to support varying types?

TypeBox currently allows for varying enum types 'string' and 'number' as TypeScript enum syntax allows for it. As such it omits the type property based on the example provided at this link...

https://cswr.github.io/JsonSchema/spec/generic_keywords/#enumerated-values

The enum keyword also allows us have different types in the list of allowed values. Consider the schema:

{
 "enum": ["Two", 2, true, null]
}

// allowed in TypeScript
enum Example {
  A = 'Two',
  B = 2,
}

Feel free to link back to this issue. There are technicalities around appropriately inferring the correct type, and how to properly deal with varying enum values in TypeBox. But am interested to see what the 'fast-json-stringify' guys come back with on this.

from typebox.

Hi @fox1t, Thanks for getting back. Glad you found a good work around. :)

Not too sure what can be done for the enum case if TypeBox is to allow both string and number enum types. Given that the type appears to be optional for enum, I'm tempted to close off this issue.

Will leave open for a week or so in-case someone wants to weight in with thoughts or rationales.

Thanks Again
S

from typebox.